Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Secure the data sent from client #135

Open
shivangg opened this issue Apr 3, 2019 · 0 comments
Open

Secure the data sent from client #135

shivangg opened this issue Apr 3, 2019 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@shivangg
Copy link
Contributor

shivangg commented Apr 3, 2019

Currently, any client can send the data to any pacman. Client 2 has access to the playerId of pacman 1 . Client 2 can change the direction of client-1's pacman by sending its playerId through updateNewDirection({playerId, direction})

An approaches to solve this issue:
Send the user JWT instead of playerId given to the server with updateNewDirection(). On the server that JWT maps to the correct playerId and updates that pacman direction. Now, the client 2 cannot update client 1 pacman.

Server will need to store the 2 user's JWT for each room.

Comments? @Shalinit3

@shivangg shivangg added the bug Something isn't working label Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants