From be81e82244f417824be9cb1ef3701385f489284a Mon Sep 17 00:00:00 2001 From: Pau Espin Pedrol Date: Wed, 20 Mar 2024 16:05:47 +0100 Subject: [PATCH] [SMF] Gy: Remove 3GPP-RAT-Type AVP from Multiple-Services-Credit-Control AVP This AVP is optional and was added in later releases of the 3GPP TS 32.299 spec. For instance, it shows up in Release 16 (V16.2.0), but doesn't show up in Release 12 (V12.7.0). Some OCS, like PortaOne OCS, implement older versions of the release (V12.14.0), and hence fail when receiving the 3GPP-RAT-Type inside Multiple-Services-Credit-Control AVP. Since nowadays we also send the 3GPP-RAT-Type in PS-Information AVP, which has been specified for longer time (it already shows up in V12.7.0), drop it from Multiple-Services-Credit-Control to have greater compatibility with other vendors. --- src/smf/gy-path.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/src/smf/gy-path.c b/src/smf/gy-path.c index 648d946cde..d6f02cff2f 100644 --- a/src/smf/gy-path.c +++ b/src/smf/gy-path.c @@ -325,16 +325,6 @@ static void fill_multiple_services_credit_control_ccr(smf_sess_t *sess, /* QoS-Information */ fill_qos_information(sess, avp); - /* 3GPP-RAT-Type, TS 29.061 16.4.7.2 21 */ - /* GGSN: TS 29.060 7.7.50, PGW: TS 29.274 8.17 */ - ret = fd_msg_avp_new(ogs_diam_gy_3gpp_rat_type, 0, &avpch1); - ogs_assert(ret == 0); - val.os.data = (uint8_t*)&sess->gtp_rat_type; - val.os.len = 1; - ret = fd_msg_avp_setvalue (avpch1, &val); - ogs_assert(ret == 0); - ret = fd_msg_avp_add (avp, MSG_BRW_LAST_CHILD, avpch1); - ogs_assert(ret == 0); /* Multiple Services AVP add to req: */ ret = fd_msg_avp_add(req, MSG_BRW_LAST_CHILD, avp); ogs_assert(ret == 0);