-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added staging configuration customization #136
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 tasks
amalnanavati
commented
May 4, 2024
amalnanavati
commented
May 4, 2024
amalnanavati
commented
May 4, 2024
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe this pull request. Link to relevant GitHub issues, if any.
This PR depends on
ada_feeding
#177.Allow users to customize the staging configuration. The staging configuration has a few unique aspects relative to the above plate and resting configuration, which are enumerated below. Those differences motivated expansions to the
CustomizeConfiguration
component.MoveToStagingconfiguration
), but also the end-effector pose (forMoveFromMouth
).In addition to expanding
CustomizeConfiguration
, this PR also makes the following changes:VideoFeed
component. Also allows the parent of theVideoFeed
component to trigger refreshes when desired, which not only refreshes the WebRTC stream but also re-toggles FaceDetection on.VideoFeed
, this PR keeps trying to resize the video until it succeeds. Because if the video is nested in many HTML elements, it may not have the parent size on the first event cycle, which is what it previously used to resize the video.moveToMouthActionGoal
to theDetectingFaceSubcomponent
, so the action goal is correctly set regardless of whether face detection is called from the main code or from the Settings Menu.BiteTransfer
andStaging
where they sent the empty action input toMoveToMouth
.Explain how this pull request was tested, including but not limited to the below checkmarks.
ada_feeding
#177, build, and start the code in real:python3 src/ada_feeding/start.py
Staging
Settings work:MoveToStaging
is properly called (e.g., it's not an old version of the function that is frozen and called).AbovePlate
customization, verify it still works as expected.Resting
customization, verify it still works as expected.MovetoMouth
goal is passed (i.e., not an empty one).Before creating a pull request
npm run format
python3 -m black .
in the top-level of this repositoryBefore merging a pull request
Squash and Merge
)