Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added dummy TableDetection and web app toggling of table detection #130

Merged
merged 3 commits into from
May 4, 2024

Conversation

amalnanavati
Copy link
Contributor

Description

This PR, joint with ada_feeding#171, implements automated table detection into the robot-assisted feedingg system. Specifically, this PR extends the web app to toggle table detection on when the app switches to bite selection, and off when the app moves away from bite selection. Further, this PR implements a dummy TableDetection node (to continue the invariant that all real ROS interfaces have dummy variants, so the app can be tested in isolation).

Testing

Dummy:

  • Launch code: python3 src/ada_feeding/start.py --sim dummy
  • Echo the table detection topic: ros2 topic echo /table_detection. Verify that nothing is being published on that topic.
  • Click “Start Feeding” in the web app. Once the app switches to Bite Selection, verify that table detection poses do start getting published.
  • Click “Skip Acquisition.” Verify that table detection poses stop being published.

Mock:

  • Launch code: python3 src/ada_feeding/start.py --sim mock
  • Click “Start Feeding” in the web app. Once the app switches to Bite Selection, verify that the table moves.

Real: see ada_feeding#171 for test cases and results.


Before creating a pull request

  • Format React code with npm run format
  • Format Python code by running python3 -m black . in the top-level of this repository
  • Thoroughly test your code's functionality, including unintended uses.
  • [N/A] Fully test the responsiveness of the feature as documented in the Responsiveness Testing Guidelines. If you deviate from those guidelines, document above why you deviated and what you did instead.
  • [N/A] Consider the user flow between states that this feature introduces, consider different situations that might occur for the user, and ensure that there is no way for the user to get stuck in a loop.

Before merging a pull request

  • Squash all your commits into one (or Squash and Merge)

@amalnanavati amalnanavati requested a review from sriramk117 April 2, 2024 23:08
Copy link
Contributor

@sriramk117 sriramk117 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and testing this code worked for me!

@sriramk117 sriramk117 merged commit b5ddf35 into main May 4, 2024
4 checks passed
@sriramk117 sriramk117 deleted the amaln/table_detector branch May 4, 2024 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants