Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Users to Zoom Into Bite Selection Video #120

Merged
merged 7 commits into from
Jan 19, 2024

Conversation

amalnanavati
Copy link
Contributor

@amalnanavati amalnanavati commented Jan 18, 2024

Describe this pull request. Link to relevant GitHub issues, if any.

Depending on the table height, the plate might only take up a small fraction of the robot's camera feed during bite selection. This makes it hard for the user to select a food item on the plate. This PR enables the user to zoom into the plate

Explain how this pull request was tested, including but not limited to the below checkmarks.

Sim:

  • Go to bite selection. Zoom in and verify it works.
  • Navigate away from bite selection and go back, verify that it has stored your old Zoom.
  • Go to DetectingFace and the live video modal, verify that the image is not zoomed there and zoom options don't show up.
  • Click on the image and verify that segmentation works.
  • Check BiteSelection in both landscape and portrait modes.
    • Note: this display is not the best, but is fine.

Real:

  • Go to bite selection. Zoom in and verify it works.
  • Navigate away from bite selection and go back, verify that it has stored your old Zoom.
  • Go to DetectingFace and the live video modal, verify that the image is not zoomed there and zoom options don't show up.
  • Click on the image and verify that segmentation works.
  • Check BiteSelection in both landscape and portrait modes.

Before creating a pull request

  • Format React code with npm run format
  • [N/A] Format Python code by running python3 -m black . in the top-level of this repository
  • Thoroughly test your code's functionality, including unintended uses.
  • Fully test the responsiveness of the feature as documented in the Responsiveness Testing Guidelines. If you deviate from those guidelines, document above why you deviated and what you did instead.
  • Consider the user flow between states that this feature introduces, consider different situations that might occur for the user, and ensure that there is no way for the user to get stuck in a loop.

Before merging a pull request

  • Squash all your commits into one (or Squash and Merge)

@amalnanavati amalnanavati merged commit 2e8f3d3 into main Jan 19, 2024
4 checks passed
@amalnanavati amalnanavati deleted the amaln/zoom_into_video branch January 19, 2024 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant