Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

K8SPSMDB-1224 Add retry mechanism for AWS CLI command in upgrade run script #1795

Merged

Conversation

ptankov
Copy link
Contributor

@ptankov ptankov commented Jan 19, 2025

CHANGE DESCRIPTION

Problem:
upgrade test fails very often, because it needs to wait a little bit before listing contects of S3 bucket.

Cause:
Short explanation of the root cause of the issue if applicable.

Solution:
I added retry just like in upgrade-sharded instead of just adding a "dumb" sleep <seconds> and it should be more stable now

CHECKLIST

Jira

  • Is the Jira ticket created and referenced properly?
  • Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
  • Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

  • Is an E2E test/test case added for the new feature/change?
  • Are unit tests added where appropriate?
  • Are OpenShift compare files changed for E2E tests (compare/*-oc.yml)?

Config/Logging/Testability

  • Are all needed new/changed options added to default YAML files?
  • Are all needed new/changed options added to the Helm Chart?
  • Did we add proper logging messages for operator actions?
  • Did we ensure compatibility with the previous version or cluster upgrade process?
  • Does the change support oldest and newest supported MongoDB version?
  • Does the change support oldest and newest supported Kubernetes version?

@pull-request-size pull-request-size bot added the size/XS 0-9 lines label Jan 19, 2025
@ptankov ptankov requested a review from egegunes January 19, 2025 07:55
@ptankov ptankov changed the title Add retry mechanism for AWS CLI command in upgrade run script K8SPSMDB-1224 Add retry mechanism for AWS CLI command in upgrade run script Jan 19, 2025
@ptankov ptankov merged commit d039aa2 into release-1.19.0 Jan 19, 2025
16 of 17 checks passed
@ptankov ptankov deleted the release-1.19.0-fix-upgrade-test-by-adding-retry branch January 19, 2025 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS 0-9 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants