Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

K8SPSMDB-1156: simplify smartUpdate if rs isn't initialized #1708

Merged
merged 5 commits into from
Nov 13, 2024

Conversation

pooknull
Copy link
Contributor

@pooknull pooknull commented Nov 7, 2024

K8SPSMDB-1156 Powered by Pull Request Badge

https://perconadev.atlassian.net/browse/K8SPSMDB-1156

DESCRIPTION

Problem:
When the cluster is deployed with spec.tls.allowInvalidCertificates: false, it enters an error state, making it impossible to update this setting to spec.tls.allowInvalidCertificates: true

Cause:
After setting spec.tls.allowInvalidCertificates: true, the operator attempts to connect to the pods of replica set, which has not been initialized.

Solution:
The operator should avoid connecting to pods during smart update if the replica set has not been initialized.

CHECKLIST

Jira

  • Is the Jira ticket created and referenced properly?
  • Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
  • Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

  • Is an E2E test/test case added for the new feature/change?
  • Are unit tests added where appropriate?
  • Are OpenShift compare files changed for E2E tests (compare/*-oc.yml)?

Config/Logging/Testability

  • Are all needed new/changed options added to default YAML files?
  • Are all needed new/changed options added to the Helm Chart?
  • Did we add proper logging messages for operator actions?
  • Did we ensure compatibility with the previous version or cluster upgrade process?
  • Does the change support oldest and newest supported MongoDB version?
  • Does the change support oldest and newest supported Kubernetes version?

@pull-request-size pull-request-size bot added the size/M 30-99 lines label Nov 7, 2024
@pooknull pooknull marked this pull request as ready for review November 11, 2024 07:50
@JNKPercona
Copy link
Collaborator

Test name Status
arbiter passed
balancer passed
custom-replset-name passed
custom-tls passed
custom-users-roles passed
custom-users-roles-sharded passed
cross-site-sharded passed
data-at-rest-encryption passed
data-sharded passed
demand-backup passed
demand-backup-fs passed
demand-backup-eks-credentials passed
demand-backup-physical passed
demand-backup-physical-sharded passed
demand-backup-sharded passed
expose-sharded passed
ignore-labels-annotations passed
init-deploy passed
finalizer passed
ldap passed
ldap-tls passed
limits passed
liveness passed
mongod-major-upgrade passed
mongod-major-upgrade-sharded passed
monitoring-2-0 passed
multi-cluster-service passed
non-voting passed
one-pod passed
operator-self-healing-chaos passed
pitr passed
pitr-sharded passed
pitr-physical passed
pvc-resize passed
recover-no-primary passed
replset-overrides passed
rs-shard-migration passed
scaling passed
scheduled-backup passed
security-context passed
self-healing-chaos passed
service-per-pod passed
serviceless-external-nodes passed
smart-update passed
split-horizon passed
storage passed
tls-issue-cert-manager passed
upgrade passed
upgrade-consistency passed
upgrade-consistency-sharded-tls passed
upgrade-sharded passed
users passed
version-service passed
We run 53 out of 53

commit: cbe0528
image: perconalab/percona-server-mongodb-operator:PR-1708-cbe0528e

@hors hors merged commit 5f9860e into main Nov 13, 2024
5 of 8 checks passed
@hors hors deleted the dev/K8SPSMDB-1156-fix-2 branch November 13, 2024 11:30
@egegunes egegunes added this to the v1.19.0 milestone Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M 30-99 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants