-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
K8SPSMDB-1032: Added possibility to specify nodeport for mongos expose #1392
Conversation
@MikeDevresse please add this new field to |
@MikeDevresse ping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please fix
? github.com/percona/percona-server-mongodb-operator/clientcmd [no test files]
# github.com/percona/percona-server-mongodb-operator/pkg/psmdb
Error: pkg/psmdb/mongos.go:441:8: i declared and not used
@MikeDevresse any updates? |
Hi sorry, checking this out asap |
Hi @MikeDevresse did you test it? I am trying to do it, but it does not work for me :( Maybe it is due to GKE. |
mhh not working ... trying to find out why, I may update the PR soon then |
Still not working, if anyone has an idea feel free to suggest, it seems that the configuration is not saved, is there a way to debug this maybe ? Edit : I tried making a test and running it, but it seems complicated even with minikube to run a local image, and I dont have the permissions to publish to perconalab so it's hard to test because it means that each time I have to wait for the CI to be completed, if anyone has a workarround to that feel free to share, would love to test this locally before commiting |
@MikeDevresse I'll check it next week and try to assist you. |
@MikeDevresse sorry for the delay, I'll check it next week. |
@MikeDevresse I tried on GKE and your code works. The example port number you put in
I changed the port number to
and then allowed traffic to this port:
and was able to connect to the database:
|
deploy/cr.yaml
Outdated
@@ -492,6 +492,7 @@ spec: | |||
# service.beta.kubernetes.io/aws-load-balancer-backend-protocol: http | |||
# serviceLabels: | |||
# rack: rack-22 | |||
# nodePort: 37017 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please change this example to a port number between 30000-32767
@MikeDevresse tests are most likely failing because of a new version of PBM. We're fixing it in another PR. I'll ping you once it gets merged so you can rebase. |
The PR which will fix PBM issues: #1485 |
@inelpandzic please review |
commit: cf23e6e |
@MikeDevresse thank you for contribution |
Added the possibility to specify nodeport for the mongos router. See #1381.
Problem:
In some infrastructure we want to specify the nodeport to maintain consistency between environments and create routing rules. In the actual state it is not possible.
Cause:
The configuration does not allow that
Solution:
Read nodeport from the expose structure and bind this to the service nodeport if the service is not per pod and the exposeType is NodePort.
CHECKLIST
Jira
Needs Doc
) and QA (Needs QA
)?Tests
compare/*-oc.yml
)?Config/Logging/Testability