K8SPSMDB-1024 fixed variable scope and make sure it always get sets

[Rockawear]

CHANGE DESCRIPTION

Problem:
*pbm-entry script is having a variable scope issue.

Cause:
*pbm-entry script is having a variable scope issue where the needed env does not get updated by the script. Instead, it keeps the initial value from the previous line even after being updated through the if statement.

Solution:

• The solution is to move the line where it's piping to a file after the variable gets set.

CHECKLIST

Jira

• Is the Jira ticket created and referenced properly? No I don't have one yet. I don't know where to create.
• Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)? No, it will not break anything, instead it's making sure it does what's intented.
• Does the Jira ticket link to the proper milestone (Fix Version field)?N/A

Tests

• Is an E2E test/test case added for the new feature/change? N/A
• Are unit tests added where appropriate? N/A
• Are OpenShift compare files changed for E2E tests (compare/*-oc.yml)? N/A

Config/Logging/Testability

• Are all needed new/changed options added to default YAML files?
• Are the manifests (crd/bundle) regenerated if needed?
• Did we add proper logging messages for operator actions?
• Did we ensure compatibility with the previous version or cluster upgrade process?
• Does the change support oldest and newest supported MongoDB version? yes, It does
• Does the change support oldest and newest supported Kubernetes version? yes, it does

[CLAassistant]

All committers have signed the CLA.

[Rockawear]

I don't know how is this test failing. I only move a line below another. This shouldn't cause this to brick. Is it possible that it was broken before my PR?

[egegunes]

@Rockawear there are some false negatives from time to time, I don't think your changes caused the failure. I restarted the test suite.

[JNKPercona]

Test name	Status
arbiter	passed
balancer	passed
custom-replset-name	passed
cross-site-sharded	passed
data-at-rest-encryption	passed
data-sharded	passed
demand-backup	passed
demand-backup-eks-credentials	passed
demand-backup-physical	passed
demand-backup-physical-sharded	passed
demand-backup-sharded	passed
expose-sharded	passed
ignore-labels-annotations	passed
init-deploy	passed
finalizer	passed
limits	passed
liveness	passed
mongod-major-upgrade	passed
mongod-major-upgrade-sharded	passed
monitoring-2-0	passed
multi-cluster-service	passed
non-voting	passed
one-pod	passed
operator-self-healing-chaos	passed
pitr	passed
pitr-sharded	passed
pitr-physical	passed
recover-no-primary	passed
rs-shard-migration	passed
scaling	passed
scheduled-backup	passed
security-context	passed
self-healing-chaos	passed
service-per-pod	passed
serviceless-external-nodes	passed
smart-update	passed
split-horizon	passed
storage	passed
tls-issue-cert-manager	passed
upgrade	passed
upgrade-consistency	passed
upgrade-consistency-sharded	passed
upgrade-sharded	passed
users	passed
version-service	passed
We run 45 out of 45

commit: 0194a6e
image: perconalab/percona-server-mongodb-operator:PR-1391-0194a6e6

[Rockawear]

@egegunes Do we have to wait for a new PSMDB release to get this change if merged? Currently, I'm unable to restore through regular psmdb-restore cr. Having this change asap would be helpful. Thanks

[hors]

@egegunes Do we have to wait for a new PSMDB release to get this change if merged? Currently, I'm unable to restore through regular psmdb-restore cr. Having this change asap would be helpful. Thanks

Hi @Rockawear, I am going to merge it today.

[Rockawear]

@hors @egegunes I guess, I won't get this until the next release. Is there a way to start using this before?

[hors]

@hors @egegunes I guess, I won't get this until the next release. Is there a way to start using this before?

@Rockawear you can create a custom operator docker image and use it as a custom init image in CR https://github.com/percona/percona-server-mongodb-operator/blob/main/deploy/cr.yaml#L22