Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

K8SPSMDB-948: Multi arch build #1356

Merged
merged 2 commits into from
Jan 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/reviewdog.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
- uses: actions/checkout@v4.1.1
- uses: actions/setup-go@v5
with:
go-version: '^1.17'
go-version: '^1.21'
- run: go install mvdan.cc/sh/v3/cmd/shfmt@latest
- run: $(go env GOPATH)/bin/shfmt -f . | grep -v 'vendor' | xargs $(go env GOPATH)/bin/shfmt -bn -ci -s -w
- name: suggester / shfmt
Expand Down
40 changes: 37 additions & 3 deletions .github/workflows/scan.yml
Original file line number Diff line number Diff line change
@@ -1,22 +1,56 @@
name: Scan docker
on: [pull_request]

env:
# Use docker.io for Docker Hub if empty
REGISTRY: docker.io

# github.repository as <account>/<repo>
IMAGE_NAME: perconalab/percona-server-mongodb-operator

jobs:
build:
name: Build
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@v4.1.1
- name: Build an image from Dockerfile

- name: Set up QEMU
uses: docker/setup-qemu-action@v3

- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v3

- name: Build an image from Dockerfile (linux/arm64)
run: |
export IMAGE=perconalab/percona-server-mongodb-operator:${{ github.sha }}
export IMAGE=${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:${{ github.sha }}-arm64
export DOCKER_PUSH=0
export DOCKER_SQUASH=0
export DOCKER_DEFAULT_PLATFORM='linux/arm64'
./e2e-tests/build
- name: Run Trivy vulnerability scanner
uses: aquasecurity/trivy-action@0.16.1
with:
image-ref: 'docker.io/perconalab/percona-server-mongodb-operator:${{ github.sha }}'
image-ref: '${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:${{ github.sha }}-arm64'
format: 'table'
exit-code: '1'
ignore-unfixed: true
vuln-type: 'os,library'
severity: 'CRITICAL,HIGH'

- name: Build an image from Dockerfile (linux/amd64)
run: |
export IMAGE=${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:${{ github.sha }}-amd64
export DOCKER_PUSH=0
export DOCKER_SQUASH=0
export DOCKER_DEFAULT_PLATFORM='linux/amd64'
./e2e-tests/build

- name: Run Trivy vulnerability scanner image (linux/amd64)
uses: aquasecurity/trivy-action@0.14.0
with:
image-ref: '${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:${{ github.sha }}-amd64'
format: 'table'
exit-code: '1'
ignore-unfixed: true
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ jobs:
steps:
- uses: actions/setup-go@v5
with:
go-version: '^1.19'
go-version: '^1.21'
- uses: actions/checkout@v4.1.1
- name: go test
run: go test -v ./...
5 changes: 3 additions & 2 deletions Jenkinsfile
Original file line number Diff line number Diff line change
Expand Up @@ -323,6 +323,7 @@ EOF
docker login -u '${USER}' -p '${PASS}'
export RELEASE=0
export IMAGE=\$DOCKER_TAG
docker buildx create --use
./e2e-tests/build
docker logout
"
Expand All @@ -349,7 +350,7 @@ EOF
-v $WORKSPACE/src/github.com/percona/percona-server-mongodb-operator:/go/src/github.com/percona/percona-server-mongodb-operator \
-w /go/src/github.com/percona/percona-server-mongodb-operator \
-e GOFLAGS='-buildvcs=false' \
golang:1.19 sh -c '
golang:1.21 sh -c '
go install github.com/google/go-licenses@v1.0.0;
/go/bin/go-licenses csv github.com/percona/percona-server-mongodb-operator/cmd/manager \
| cut -d , -f 3 \
Expand Down Expand Up @@ -377,7 +378,7 @@ EOF
-v $WORKSPACE/src/github.com/percona/percona-server-mongodb-operator:/go/src/github.com/percona/percona-server-mongodb-operator \
-w /go/src/github.com/percona/percona-server-mongodb-operator \
-e GOFLAGS='-buildvcs=false' \
golang:1.19 sh -c 'go build -v -o percona-server-mongodb-operator github.com/percona/percona-server-mongodb-operator/cmd/manager'
golang:1.21 sh -c 'go build -v -o percona-server-mongodb-operator github.com/percona/percona-server-mongodb-operator/cmd/manager'
"
'''

Expand Down
5 changes: 2 additions & 3 deletions build/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -7,17 +7,16 @@ ARG GIT_COMMIT
ARG GIT_BRANCH
ARG GO_LDFLAGS
ARG GOOS=linux
ARG GOARCH=amd64
ARG CGO_ENABLED=0

RUN go mod download \
&& mkdir -p build/_output/bin \
&& GOOS=$GOOS GOARCH=$GOARCH CGO_ENABLED=$CGO_ENABLED GO_LDFLAGS=$GO_LDFLAGS \
&& GOOS=$GOOS CGO_ENABLED=$CGO_ENABLED GO_LDFLAGS=$GO_LDFLAGS \
go build -ldflags "-w -s -X main.GitCommit=$GIT_COMMIT -X main.GitBranch=$GIT_BRANCH" \
-o build/_output/bin/percona-server-mongodb-operator \
cmd/manager/main.go \
&& cp -r build/_output/bin/percona-server-mongodb-operator /usr/local/bin/percona-server-mongodb-operator \
&& GOOS=$GOOS GOARCH=$GOARCH CGO_ENABLED=$CGO_ENABLED GO_LDFLAGS=$GO_LDFLAGS \
&& GOOS=$GOOS CGO_ENABLED=$CGO_ENABLED GO_LDFLAGS=$GO_LDFLAGS \
go build -ldflags "-w -s -X main.GitCommit=$GIT_COMMIT -X main.GitBranch=$GIT_BRANCH" \
-o build/_output/bin/mongodb-healthcheck \
cmd/mongodb-healthcheck/main.go \
Expand Down
15 changes: 9 additions & 6 deletions e2e-tests/build
Original file line number Diff line number Diff line change
Expand Up @@ -14,28 +14,31 @@ fi
if [[ ${DOCKER_SQUASH:-1} == 1 ]]; then
squash="--squash"
fi
if [[ ${DOCKER_PUSH:-1} == 1 ]]; then
imgresult="--push=true"
else
imgresult="--load"
fi

build_operator() {
if [ "${RELEASE:-1}" = 0 ]; then
GO_LDFLAGS="-race"
fi

export IMAGE
export DOCKER_DEFAULT_PLATFORM=${DOCKER_DEFAULT_PLATFORM:-linux/amd64}
export DOCKER_DEFAULT_PLATFORM=${DOCKER_DEFAULT_PLATFORM:-"linux/amd64,linux/arm64"}
export GO_LDFLAGS="-w -s -trimpath $GO_LDFLAGS"
pushd ${src_dir}
docker build \
docker buildx build \
--platform $DOCKER_DEFAULT_PLATFORM \
--build-arg GIT_COMMIT=$GIT_COMMIT \
--build-arg GIT_BRANCH=$GIT_BRANCH \
--build-arg GO_LDFLAGS="$GO_LDFLAGS" \
$imgresult \
$squash \
$no_cache \
-t "${IMAGE}" -f build/Dockerfile .
popd

if [ "${DOCKER_PUSH:-1}" = 1 ]; then
docker push ${IMAGE}
fi
}

until docker ps; do sleep 1; done
Expand Down
Loading