PMM-13748 gssapi support #1042
Open
PMM-13748 gssapi support #1042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idoqo
requested review from
BupycHuk,
JiriCtvrtka and
ademidoff
and removed request for
a team
BupycHuk
approved these changes
Mar 6, 2025
docker-compose.yml
Outdated
Comment on lines
290
to
291
| build: | ||
| dockerfile: ./docker/kerberos.dockerfile |
There was a problem hiding this comment.
can we have pre-built docker image, so we don' have to build it everytime
ademidoff
reviewed
Mar 11, 2025
Makefile
Outdated
| @@ -71,7 +71,7 @@ init: ## Install linters | |||
| cd tools && go generate -x -tags=tools | |||
|
|
|||
| build: ## Compile using plain go build | |||
| go build -ldflags="$(GO_BUILD_LDFLAGS)" -o $(PMM_RELEASE_PATH)/mongodb_exporter | |||
| env CGO_ENABLED=1 go build -ldflags="$(GO_BUILD_LDFLAGS)" -o $(PMM_RELEASE_PATH)/mongodb_exporter -tags gssapi | |||
There was a problem hiding this comment.
Suggested change
| env CGO_ENABLED=1 go build -ldflags="$(GO_BUILD_LDFLAGS)" -o $(PMM_RELEASE_PATH)/mongodb_exporter -tags gssapi | |
| CGO_ENABLED=1 go build -ldflags="$(GO_BUILD_LDFLAGS)" -o $(PMM_RELEASE_PATH)/mongodb_exporter -tags gssapi |
There is no need to pass all of the environment variables to Go.
exporter/exporter_test.go
Outdated
| "mongodb_up", | ||
| } | ||
| err = testutil.CollectAndCompare(gc, expected, filter...) | ||
| assert.NoError(t, err, "mongodb_up metric should be 1") |
There was a problem hiding this comment.
Suggested change
| assert.NoError(t, err, "mongodb_up metric should be 1") | |
| require.NoError(t, err, "mongodb_up metric should be 1") |
| @@ -0,0 +1,4 @@ | |||
| #!/bin/bash | |||
|
|
|||
| docker exec --user root psmdb-kerberos bash -c 'chown mongodb:root /krb5/mongodb.keytab' | |||
There was a problem hiding this comment.
Suggested change
| docker exec --user root psmdb-kerberos bash -c 'chown mongodb:root /krb5/mongodb.keytab' | |
| docker exec --user root psmdb-kerberos bash -c 'chown mongodb:mongodb /krb5/mongodb.keytab' |
There was a problem hiding this comment.
Looks like there's no mongodb group, only the user.
| password=${MONGO_INITDB_ROOT_PASSWORD} | ||
|
|
||
| echo "Waiting for startup.." | ||
| until mongosh --host 127.0.0.1:27017 -u ${username} -p ${password} --eval 'quit(db.runCommand({ ping: 1 }).ok ? 0 : 2)' &>/dev/null; do |
There was a problem hiding this comment.
This will loop forever if it's unable to connect. Shall we consider a timeout or a number of retries?
JiriCtvrtka
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PMM-13748
This adds support for the GSSAPI auth mechanism for the exporter by compiling the binary with the
-tags gssapiflag. It also adds additional kerberos environment (via docker) for tests.