Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typings for impls #704

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Fix typings for impls #704

merged 1 commit into from
Mar 7, 2024

Conversation

jessepinho
Copy link
Contributor

Per @grod220 's comment here

@jessepinho jessepinho requested review from grod220 and turbocrime March 7, 2024 18:19
@jessepinho jessepinho marked this pull request as ready for review March 7, 2024 18:19
grod220
grod220 approved these changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@grod220 grod220 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jessepinho jessepinho merged commit 6c91054 into main Mar 7, 2024
6 checks passed
@jessepinho jessepinho deleted the jessepinho/impl-types branch March 7, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grod220 grod220 grod220 approved these changes

@turbocrime turbocrime Awaiting requested review from turbocrime

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jessepinho @grod220