Fix logic for whether we're currently catching up #698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's currently backwards.
jessepinho
commented
Mar 6, 2024
Comment on lines
+31
to
+33
| getWalletServices: vi.fn(() => | ||
| Promise.resolve({ indexedDb: mockIndexedDb }), | ||
| ) as MockServices['getWalletServices'], |
There was a problem hiding this comment.
Fixes a TypeScript complaint
grod220
approved these changes
Mar 6, 2024
| @@ -9,7 +9,7 @@ export const status: Impl['status'] = async (_, ctx) => { | |||
| if (!fullSyncHeight) throw new Error('Last block synced not in db'); | |||
|
|
|||
| return { | |||
| catchingUp: fullSyncHeight === latestBlockHeight, | |||
| catchingUp: fullSyncHeight !== latestBlockHeight, | |||
There was a problem hiding this comment.
Ah good catch. It's an edge case (maybe an error somewhere else if so), but should we do:
catchingUp: fullSyncHeight < latestBlockHeight,
There was a problem hiding this comment.
https://github.com/penumbra-zone/penumbra/blob/d3bbe4c920dd03981ed883d347ed579dae6af363/crates/view/src/service.rs#L326-L334
rust view service also returns catchingUp=false if the difference is only 1 block
Valentine1898
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's currently backwards.