Build UI for claiming unbonding tokens #659

jessepinho · 2024-03-02T06:58:06Z

Initial UI for claiming unbonding tokens.

undelegate-claim.mov

🚨 This will automatically attempt to claim all unbonding tokens that the current address holds, even if some of them are not yet eligible for claiming. In that case, an error will show up, saying that we're not yet in the right epoch for claiming unbonding tokens. At the moment, there's no RPC method to detect which unbonding tokens are eligible for claiming and which aren't . When there is, we can automatically select just the eligible tokens and claim those. Until then, we'll just cross our fingers :D

In this PR

Create an undelegateClaim action in the Staking slice, as well as in the WASM planner.
Create a client for the SCT service (to get the current epoch).
Implement the ValidatorPenalty method of StakingService, which is required for an undelegation claim.
Fix a bug with how proving keys were being loaded.
Move staking slice into its own directory.

Closes #655

jessepinho · 2024-03-05T23:46:19Z

package.json

+    "@buf/penumbra-zone_penumbra.bufbuild_es": "1.7.2-20240304191729-7e25957407d1.1",
+    "@buf/penumbra-zone_penumbra.connectrpc_es": "1.4.0-20240304191729-7e25957407d1.1",


Updating to the version that includes undelegation claims in TransactionPlannerRequest

jessepinho · 2024-03-06T00:36:58Z

apps/webapp/src/components/staking/account/header/index.tsx

-                        {unbondingTokens?.tokens.map(token => (
-                          <ValueViewComponent key={getDisplayDenomFromView(token)} view={token} />
-                        ))}
+              <TooltipProvider>


All I did here was make the entire unbonding amount ValueViewComponent the tooltip trigger, rather than having the little (i) icon as the trigger

jessepinho · 2024-03-06T00:56:15Z

packages/query/src/queriers/tendermint.ts

+  'cannot claim unbonding tokens before the end epoch',
+  'undelegation was prepared for next epoch',


Unrelated to this PR, see penumbra-zone/penumbra#3961.

These messages are actually in the core repo — not Tendermint itself. Thus, they can (and probably should) be changed to include a machine-readable error code, rather than us having to parse human-readable text.

jessepinho · 2024-03-08T22:53:09Z

packages/ui/components/ui/tx/view/action-details.tsx

+ * </ActionDetails>
+ * ```
+ */
+export const ActionDetails = ({ children }: { children: ReactNode }) => {


jessepinho · 2024-03-08T22:55:13Z

packages/ui/components/ui/tx/view/viewbox.tsx

@@ -13,7 +13,7 @@ export const ViewBox = ({ label, visibleContent }: ViewBoxProps) => {
  return (
    <div
      className={cn(
-        'bg-background px-4 pt-3 pb-4 rounded-lg border flex flex-col gap-1 break-all',
+        'bg-background px-4 pt-3 pb-4 rounded-lg border flex flex-col gap-1 break-all overflow-hidden',


Fixes an issue where the view box would stretch beyond its parents bounds if its children were too big.

jessepinho · 2024-03-08T22:55:33Z

packages/wasm/crate/Cargo.toml

-penumbra-stake         = { git = "https://github.com/penumbra-zone/penumbra.git", tag = "v0.68.2", package = "penumbra-stake", default-features = false }
-penumbra-tct           = { git = "https://github.com/penumbra-zone/penumbra.git", tag = "v0.68.2", package = "penumbra-tct" }
-penumbra-transaction   = { git = "https://github.com/penumbra-zone/penumbra.git", tag = "v0.68.2", package = "penumbra-transaction", default-features = false }
+penumbra-asset         = { git = "https://github.com/penumbra-zone/penumbra.git", tag = "v0.68.3", package = "penumbra-asset" }


Updated to get the latest version of TransactionPlannerRequest, which now includes undelegation claims

jessepinho · 2024-03-08T23:26:38Z

packages/wasm/src/build.ts

@@ -59,6 +59,6 @@ export const buildActionParallel = async (
 const loadProvingKey = async (actionType: ActionType) => {
  const keyType = provingKeys[actionType];
  if (!keyType) return;
-  const keyBin = (await fetch(`bin/${actionType}_pk.bin`)).arrayBuffer();
+  const keyBin = (await fetch(`bin/${keyType}_pk.bin`)).arrayBuffer();


Fixes a bug where the proving key wasn't being fetched correctly. We didn't notice this earlier because actionType and keyType are the same for the more common actions, but I noticed it while working on undelegation claims because the undelegateClaim action uses a convert key.

oh! Good catch.

jessepinho · 2024-03-08T23:31:45Z

apps/minifront/src/state/staking/index.ts

@@ -279,6 +284,50 @@ export const createStakingSlice = (): SliceCreator<StakingSlice> => (set, get) =
      });
    }
  },
+  undelegateClaim: async () => {


These state methods that build and submit a transaction, as well as manage toasts, are quite repetitive. I want to DRY them up, but this PR is already pretty huge (sorry), so I'll do that in a future PR.

Can you create an issue for that 🙏 ?

grod220

Good job!

At the moment, there's no RPC method to detect which unbonding tokens are eligible for claiming and which aren't

Can you create an issue for this and add it to the staking tracking issue?

grod220 · 2024-03-11T10:34:03Z

apps/minifront/src/state/staking/index.ts

@@ -279,6 +284,50 @@ export const createStakingSlice = (): SliceCreator<StakingSlice> => (set, get) =
      });
    }
  },
+  undelegateClaim: async () => {


Can you create an issue for that 🙏 ?

grod220 · 2024-03-11T10:38:32Z

packages/wasm/src/build.ts

@@ -59,6 +59,6 @@ export const buildActionParallel = async (
 const loadProvingKey = async (actionType: ActionType) => {
  const keyType = provingKeys[actionType];
  if (!keyType) return;
-  const keyBin = (await fetch(`bin/${actionType}_pk.bin`)).arrayBuffer();
+  const keyBin = (await fetch(`bin/${keyType}_pk.bin`)).arrayBuffer();


oh! Good catch.

This reverts commit bb27e46.

jessepinho · 2024-03-12T14:22:15Z

@grod:

At the moment, there's no RPC method to detect which unbonding tokens are eligible for claiming and which aren't

Can you create an issue for this and add it to the staking tracking issue?

I believe @erwanor was already working on this... @erwanor , is there a ticket for this RPC method?

jessepinho · 2024-03-12T16:37:26Z

@grod220 Nevermind — just created the ticket after discussing with @erwanor . penumbra-zone/penumbra#4006

jessepinho force-pushed the jessepinho/web-588-unbonding-tokens branch from 4729534 to 8f90a65 Compare March 4, 2024 20:41

Base automatically changed from jessepinho/web-588-unbonding-tokens to main March 4, 2024 20:56

jessepinho force-pushed the jessepinho/web-655-undelegate-claims branch 10 times, most recently from 09def59 to 0661d14 Compare March 5, 2024 22:12

jessepinho commented Mar 5, 2024

View reviewed changes

jessepinho commented Mar 6, 2024

View reviewed changes

jessepinho force-pushed the jessepinho/web-655-undelegate-claims branch 4 times, most recently from 0e494ae to 03d9871 Compare March 8, 2024 21:39

jessepinho commented Mar 8, 2024

View reviewed changes

jessepinho force-pushed the jessepinho/web-655-undelegate-claims branch from 024cbbb to b0c1e3e Compare March 8, 2024 23:25

jessepinho commented Mar 8, 2024

View reviewed changes

jessepinho marked this pull request as ready for review March 9, 2024 02:10

jessepinho changed the title ~~WIP: Build UI for claiming unbonding tokens~~ Build UI for claiming unbonding tokens Mar 9, 2024

jessepinho requested review from grod220 and turbocrime March 9, 2024 02:10

grod220 approved these changes Mar 11, 2024

View reviewed changes

jessepinho added 25 commits March 12, 2024 07:14

Account for undelegate claims in the planner

335a391

Install missing dep

42c73d6

Fix merge conflict issue

a3f1f54

Put all claims into one transaction

74ff78a

Remove unnecessary loader call

045d6f8

Fix typo

d647e68

Account for more errors from tendermint

7ffce35

Make the entire unbonding amount a tooltip

a5f1343

Update deps to take advantage of TransactionPlanner RPC change

b23c832

Add validatorPenalty to the Staking querier

444b630

Add a validatorPenalty method handler to our impl of Staking

45fd748

Create ActionDetails component

a45c3bc

Add getters for undelegate claims

d1b3ba3

Display undelegate claims

abe99e7

Fix layout issue

0e67178

Extract Separator component

50027a5

Tweak comment

99fec08

Fix bug with loading proving key

c5c3211

Extract a helper

ca1b118

Put staking slice in its own directory and extract a helper

51965f5

Fix Rust tests

2173cf5

Run delegate script synchronously to avoid conflicts etc.

5568c61

Polyfill Array.fromAsync in our test environment

07ad652

Fix mock paths

035a065

Revert "Polyfill Array.fromAsync in our test environment"

4552ea7

This reverts commit bb27e46.

jessepinho force-pushed the jessepinho/web-655-undelegate-claims branch from 2ce6a77 to 4552ea7 Compare March 12, 2024 14:15

jessepinho merged commit f06c2a8 into main Mar 12, 2024
6 checks passed

jessepinho deleted the jessepinho/web-655-undelegate-claims branch March 12, 2024 14:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Build UI for claiming unbonding tokens #659

Build UI for claiming unbonding tokens #659

jessepinho commented Mar 2, 2024 •

edited

Loading

jessepinho Mar 5, 2024

jessepinho Mar 6, 2024

jessepinho Mar 6, 2024

jessepinho Mar 8, 2024

jessepinho Mar 8, 2024

jessepinho Mar 8, 2024

jessepinho Mar 8, 2024

grod220 Mar 11, 2024

jessepinho Mar 8, 2024

grod220 Mar 11, 2024

grod220 left a comment

grod220 Mar 11, 2024

grod220 Mar 11, 2024

jessepinho commented Mar 12, 2024

jessepinho commented Mar 12, 2024

		"@buf/penumbra-zone_penumbra.bufbuild_es": "1.7.2-20240304191729-7e25957407d1.1",
		"@buf/penumbra-zone_penumbra.connectrpc_es": "1.4.0-20240304191729-7e25957407d1.1",

		'cannot claim unbonding tokens before the end epoch',
		'undelegation was prepared for next epoch',

Build UI for claiming unbonding tokens #659

Build UI for claiming unbonding tokens #659

Conversation

jessepinho commented Mar 2, 2024 • edited Loading

In this PR

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

grod220 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jessepinho commented Mar 12, 2024

jessepinho commented Mar 12, 2024

jessepinho commented Mar 2, 2024 •

edited

Loading