Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minimize changes, improve stream reliability, avoid async races #2066

Merged

Conversation

turbocrime
Copy link
Collaborator

@turbocrime turbocrime commented Feb 20, 2025

minimizes diff with main. deletes client-streaming support.

Issues with connection-lifecycle-branch included

  • stalled streams don't fail
  • async validation of senders before listener attach may drop early requests

Solutions:

  • add timeout to streams
  • attach listeners immediately, but block execution on validation promise

@turbocrime turbocrime requested a review from TalDerei February 20, 2025 09:42
Copy link

changeset-bot bot commented Feb 20, 2025

⚠️ No Changeset found

Latest commit: 03edfc9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@turbocrime turbocrime mentioned this pull request Feb 20, 2025
1 task
@turbocrime turbocrime marked this pull request as ready for review February 20, 2025 10:42
@turbocrime turbocrime merged commit ea99e56 into connection-lifecycle-branch Feb 20, 2025
6 checks passed
@turbocrime turbocrime deleted the prevent-transport-race-conditions branch February 20, 2025 10:48
@turbocrime turbocrime mentioned this pull request Feb 20, 2025
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant