fix(ui): stop XL font responsiveness #1990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0f2767b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Visit the preview URL for this PR (updated for commit 0f2767b): https://penumbra-ui-preview--pr1990-fix-font-responsiven-qs5s76z0.web.app (expires Thu, 30 Jan 2025 13:40:26 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 709d729610ef7a6369b23f1cb2b820a60cc685b1 |
JasonMHasperhoven
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes penumbra-zone/dex-explorer#307
This PR simply comments out the XL screen size responsiveness.
Context
Sam and Artur made UI typography styles responsive, so, for example, a
text-textBaseclass is 0.875rem (14px) on mobile and tablet screens, 1rem (16px) on desktop and large screens, 1.125rem (18px) on XL screens.This feature was implemented in #1978 to meet the v2 designs requirements. This lead to mobile and tablet screens become pixel-perfect, better-looking for users of the DEX. However, DEX designs do not support XL text responsiveness as the components are extremely dense and need smaller text styles.
For text style reference, see the screenshots in #1978