Add trailingZeros option to ValueView

[JasonMHasperhoven]

No description provided.

[changeset-bot]

🦋 Changeset detected

Latest commit: bd3995f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@penumbra-zone/ui	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

Visit the preview URL for this PR (updated for commit bd3995f):

https://penumbra-ui-preview--pr1949-valueview-trailing-z-b3dlliw3.web.app

_{(expires Wed, 25 Dec 2024 14:23:38 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: 709d729610ef7a6369b23f1cb2b820a60cc685b1}

[grod220]

Perhaps next time the description would help, but could you give more detail on the use-case for this? Why are trailing zeros desirable in some cases?

[VanishMax]

I guess the reason for this is that toFormattedString's trailingZeros param is true by default. This options is not for adding trailing zeros but for removing them. If that is the case, I think we can type the param as trailingZeros?: false, since passing true does nothing.

Agree that it needs some more description

[grod220]

If trailing zeros are never really desirable, how about we just set trailingZeroes on toFormattedString to false?

[JasonMHasperhoven]

Oh sorry, here you can see in the design that we should 2 decimals for UM for example:

As Max mentioned, toFormattedString shows trailingZero's by default whereas toNumber does not.

[JasonMHasperhoven]

And I still keep the default to false, as to keep the implementation the same as before (not changing it everywhere it's used)