Skip to content

feat(ui): TextInput updates #1942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 11, 2024
Merged

feat(ui): TextInput updates #1942

merged 5 commits into from
Dec 11, 2024

Conversation

VanishMax
Copy link
Contributor

@VanishMax VanishMax commented Dec 11, 2024 •
edited
Loading

In this PR:

  • Refactored Text component, added variant property to manage dynamic font types, added new text styles
  • Refactored Density component, added variant property to manage dynamic density types
  • Synced TextInput styles with the latest Figma
  • Fixed figma mismatches in the AddressView component
  • Fixed iconOnly="adornment" prop in Button component to match IconAdornment in Figma

Checks TextInput, Typography, IconAdornment in #1937

Interactive: https://penumbra-ui-preview--pr1942-feat-text-input-upda-7qlsewow.web.app/?path=/docs/ui-library-textinput--docs

@VanishMax VanishMax requested review from TalDerei and a team December 11, 2024 09:49
@VanishMax VanishMax self-assigned this Dec 11, 2024
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 11, 2024

⚠️ No Changeset found

Latest commit: 0525795

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 11, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit 56146cf):

https://penumbra-ui-preview--pr1942-feat-text-input-upda-7qlsewow.web.app

(expires Wed, 18 Dec 2024 09:52:10 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 709d729610ef7a6369b23f1cb2b820a60cc685b1

This was referenced Dec 11, 2024
Open
Merged
TalDerei
TalDerei approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@TalDerei TalDerei left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

can you add a changeset?

packages/ui/src/AddressView/index.tsx
</Text>
) : (
<Text small truncate={truncate}>
<Text variant={density === 'sparse' ? 'strong' : 'small'} truncate={truncate}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: variant property on density is a nice feature

@VanishMax
Copy link
Contributor Author

Somehow changeset bot didn't notice that the changeset exists in this PR

@VanishMax VanishMax merged commit 7969f77 into main Dec 11, 2024
8 checks passed
@VanishMax VanishMax deleted the feat/text-input-updates branch December 11, 2024 19:45
@VanishMax VanishMax mentioned this pull request Dec 19, 2024
Merged
TalDerei pushed a commit that referenced this pull request Mar 6, 2025
@VanishMax
feat(ui): TextInput updates (#1942)
81f7476 
* feat: update TextInput styles

* feat: add `variant` property to Text component, simplify code

* feat(ui): add `variant` prop to Density component

* fix(ui): match AddressView with the latest styles

* chore: changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TalDerei TalDerei TalDerei approved these changes

Assignees

@VanishMax VanishMax

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VanishMax @TalDerei