Update to types w/ useCompatAddress #1623
Conversation
🦋 Changeset detectedLatest commit: ab3e976 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| /** | ||
| * For Noble specifically we need to use a Bech32 encoding rather than Bech32m, | ||
| * because Noble currently has a middleware that decodes as Bech32. | ||
| * Noble plans to change this at some point in the future but until then we need | ||
| * to use a special encoding just for Noble specifically. | ||
| */ | ||
| const bech32Chains = ['noble', 'nobletestnet']; |
There was a problem hiding this comment.
Moved to shared file
turbocrime
force-pushed
the
use-compat
branch
5 times, most recently
from
8eae484 to
6c31d64
Compare
.syncpackrc
Outdated
There was a problem hiding this comment.
bufbuild is on version 2 now (breaking) so we needed some semver config to prevent syncpack from encouraging upgrade
| "@buf/cosmos_ibc.bufbuild_es": "1.10.0-20230913112312-7ab44ae956a0.1", | ||
| "@buf/cosmos_ibc.connectrpc_es": "1.4.0-20230913112312-7ab44ae956a0.3", |
There was a problem hiding this comment.
these two moved backwards, because i noticed it's what core uses https://github.com/penumbra-zone/penumbra/blob/main/proto/buf.lock
grod220
changed the title
grod220
changed the title
There was a problem hiding this comment.
@grod220 we'll temporarily experience slower proving (~25% performance regression) by bumping decaf377 to v0.10.1. I'll test penumbra-zone/decaf377#108 to validate it resolves the issue.
|
@TalDerei, wish we could bump without the update, but it won't compile with our old version on anything 0.79.0 and up. Because we need the types, we don't have a choice. But those performance improvements seem very worthwhile. |
|
Backing up a bit, how did we end up in a situation where these are coupled together? Agree that getting this unstuck is more important but ideally we shouldn't be in this situation. |
Part 1 of #1656
Updates to latest bufbuild and penumbra core types