Delegator voting tests #1480
Merged
Delegator voting tests #1480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 272de24 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
grod220
commented
Jul 15, 2024
Comment on lines
+151
to
+160
| let tx_planner_req = TransactionPlannerRequest::decode(request)?; | ||
| let fvk: FullViewingKey = FullViewingKey::decode(full_viewing_key)?; | ||
| let fee_asset_id = Id::decode(gas_fee_token)?; | ||
| let constants: DbConstants = serde_wasm_bindgen::from_value(idb_constants)?; | ||
| let storage = init_idb_storage(constants).await?; | ||
|
|
||
| let plan = plan_transaction_inner(storage, tx_planner_req, fvk, fee_asset_id).await?; | ||
|
|
||
| Ok(serde_wasm_bindgen::to_value(&plan)?) | ||
| } |
There was a problem hiding this comment.
Created plan_transaction_inner() in order to separate the serde serialization from the core logic of the function (that gets tested in the test suite).
grod220
commented
Jul 15, 2024
Comment on lines
+97
to
+100
| if let Some(id) = asset_id { | ||
| if record.note.asset_id() != id { | ||
| continue; | ||
| } |
There was a problem hiding this comment.
Bug fix 🐞 : The query should respect passing a None. Currently breaks delegator vote planning.
Valentine1898
approved these changes
Jul 16, 2024
Comment on lines
77
to
80
| asset_id: asset::Cache::with_known_assets() | ||
| .get_unit("upenumbra") | ||
| .unwrap() | ||
| .id(), |
There was a problem hiding this comment.
It's up to you, but you can simplify it to
asset_id: *STAKING_TOKEN_ASSET_ID,
There was a problem hiding this comment.
oh nice, will update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from #1426 & #1427
Now that we have a reasonable mock testing framework, wrote full-coverage tests for delegator voting.