Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(minifront): #1391: display filled icon for the active auction #1476

Merged
merged 5 commits into from
Jul 23, 2024

Conversation

VanishMax
Copy link
Contributor

Closes #1391

Shows the green checkmark icon for all filled dutch auctions

@VanishMax VanishMax self-assigned this Jul 15, 2024
Copy link

changeset-bot bot commented Jul 15, 2024

⚠️ No Changeset found

Latest commit: 288c440

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@VanishMax VanishMax requested a review from a team July 15, 2024 13:24
@grod220
Copy link
Contributor

grod220 commented Jul 22, 2024

Can you show a screenshot of the new design?

@VanishMax
Copy link
Contributor Author

@grod220 Unfortunately can't figure out how to run the dutch auction these days...

@Valentine1898
Copy link
Contributor

@grod220 Unfortunately can't figure out how to run the dutch auction these days...

You can create an auction in testnet (and probably in devnet too) if you manually set the Maximum and Minimum values for the auction.

See the video from this issue (the bug is not related to this PR)
#1532

@VanishMax
Copy link
Contributor Author

@Valentine1898 Thanks, I completely forgot that min and max are inputs. Hopefully will be changed soon with new designs.

Here's the screenshot that shows a green icon progressing towards the end of the auction

image

@VanishMax VanishMax merged commit 26bd932 into main Jul 23, 2024
6 checks passed
@VanishMax VanishMax deleted the fix/#1391-dutch-indicator-icon branch July 23, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auction icons positioning
3 participants