Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wildcard exports #750

Closed
Tracked by #729
grod220 opened this issue Mar 13, 2024 · 0 comments · Fixed by #756
Closed
Tracked by #729

Wildcard exports #750

grod220 opened this issue Mar 13, 2024 · 0 comments · Fixed by #756
Assignees
Labels
deps update Update of project dependencies infra Low-level infrastructure updates

Comments

@grod220
Copy link
Contributor

grod220 commented Mar 13, 2024

As of #672 external packages have verbose exports:

https://github.com/penumbra-zone/web/blob/main/packages/types/package.json#L9-L36

Using a wildcard can simply this. Example:

"exports": {
".": "./src/index.ts",
"./*": "./src/*.ts"

It looks simple, but getting this right is tricky (oh dev ops) and requires running pnpm build a million times.

@grod220 grod220 added deps update Update of project dependencies infra Low-level infrastructure updates labels Mar 13, 2024
@github-project-automation github-project-automation bot moved this to 🗄️ Backlog in Penumbra web Mar 13, 2024
@grod220 grod220 self-assigned this Mar 14, 2024
@grod220 grod220 moved this from 🗄️ Backlog to 🏗 In progress in Penumbra web Mar 14, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Penumbra web Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deps update Update of project dependencies infra Low-level infrastructure updates
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant