Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

displaying improper fee metadata #1459

Closed
TalDerei opened this issue Jul 10, 2024 · 1 comment
Closed

displaying improper fee metadata #1459

TalDerei opened this issue Jul 10, 2024 · 1 comment
Assignees
Labels
bug Something isn't working ui Related to user interface or ux design

Comments

@TalDerei
Copy link
Contributor

TalDerei commented Jul 10, 2024

In the process of prax-wallet/prax#85 and #1419, which specifically addressed the rendering of fees in the transaction approval dialogue and transaction details page for swaps, there have been several stacked changes that seemed to have caused a regression. As a result, the proper fee denomination is no longer being rendered correctly in the approval dialogue and transaction details page.

Additionally, the fee estimation in minifront needs to display the proper fee denom. cc @vacekj

@TalDerei TalDerei added bug Something isn't working ui Related to user interface or ux design labels Jul 10, 2024
@github-project-automation github-project-automation bot moved this to 🗄️ Backlog in Penumbra web Jul 10, 2024
@TalDerei TalDerei self-assigned this Jul 10, 2024
@TalDerei TalDerei moved this to 🗄️ Backlog in Labs web Jul 10, 2024
@TalDerei TalDerei moved this from 🗄️ Backlog to 📝 Todo in Labs web Jul 10, 2024
@TalDerei
Copy link
Contributor Author

TalDerei commented Jul 10, 2024

update: cargo run --release --bin pd testnet generate produces a testnet genesis file where the FeeParameters are set to zero, which accurately reflects the regressions we're seeing on the testnet.

      GasPrices {
            "asset_id": {
              "inner": "KeqcLzNx9qSH5+lcJHBB9KNW+YPrBk5dKzvPMiypahA="
            },
            "block_space_price": "1000",
            "compact_block_space_price": "5000", 
            "verification_price": "1000", 
            "execution_price": "1000"
          },
      }

On mainnet, the fee parameters in the genesis file are non-zero, so this is not an issue there. To sanity check, modifying the testnet genesis parameters to match the mainnet genesis parameters resolves this.

However, the fee estimation in minifront using the fixed staking asset denomination remains incorrect.

@TalDerei TalDerei changed the title displaying improper fee denoms displaying improper fee metadata Jul 11, 2024
@TalDerei TalDerei moved this from 📝 Todo to 🏗 In progress in Labs web Jul 12, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Labs web Jul 18, 2024
@github-project-automation github-project-automation bot moved this from 🗄️ Backlog to ✅ Done in Penumbra web Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ui Related to user interface or ux design
Projects
Archived in project
Development

No branches or pull requests

2 participants