fix: mobile styles for positions block #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TalDerei
reviewed
Jan 20, 2025
|
@VanishMax any updates with the rendering? |
# Conflicts: # src/pages/trade/ui/positions/index.tsx
|
@VanishMax what's the status of this PR? |
|
@TalDerei yes, i plan on finishing this after the current work on 'my trades' |
|
@TalDerei the fix is ready |
JasonMHasperhoven
approved these changes
Feb 10, 2025
|
@VanishMax retro reviewed and the mobile rendering appears to be fixed 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, DEX on mobile is overly stretched (965px for 375px-mobile screen, see screenshot), which causes bugs to all other blocks like summary and chart. This PR fixes it by adding correct overflow.
Before: