Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace old email penn directory with new API #172

Merged
merged 4 commits into from
Jul 8, 2024
Merged

Replace old email penn directory with new API #172

merged 4 commits into from
Jul 8, 2024

Conversation

Clue88
Copy link
Contributor

@Clue88 Clue88 commented Jul 6, 2024

@Clue88 Clue88 force-pushed the penn-directory-oauth2 branch from 3e79e87 to d51820b Compare July 6, 2024 18:42
@Clue88 Clue88 requested a review from joyliu-q July 6, 2024 18:43
joyliu-q
joyliu-q approved these changes Jul 6, 2024
View reviewed changes
Copy link
Contributor

@joyliu-q joyliu-q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Clue88 Clue88 force-pushed the penn-directory-oauth2 branch 4 times, most recently from bf7f77a to 1344b6c Compare July 7, 2024 18:06
@Clue88 Clue88 force-pushed the penn-directory-oauth2 branch from 1344b6c to bf352ac Compare July 7, 2024 18:11
@Clue88 Clue88 merged commit 7fcb949 into master Jul 8, 2024
7 checks passed
@Clue88 Clue88 deleted the penn-directory-oauth2 branch July 8, 2024 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joyliu-q joyliu-q joyliu-q approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Clue88 @joyliu-q