Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update utils.py #3663

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Update utils.py #3663

merged 1 commit into from
Feb 28, 2024

Conversation

Nazarinh0
Copy link
Contributor

For cyrillic names on social accounts - the encode and decode operations result in replacing all chars with empty string. And later in try-except block clean_username does not raise a ValidationError, so empty string username is considered valid. As a result, "user" is returned at first iteration and other txts are not even being processed. For example, I have last name, email, username on my social account, which is in latin alphabet and would be suitable for use as a username, I still will be called "user" because of cyrillic name. This issue may affect all non-latin names or last names including russian, chinese, arabic and so on.

Submitting Pull Requests

General

  • Make sure you use semantic commit messages.
    Examples: "fix(google): Fixed foobar bug", "feat(accounts): Added foobar feature".
  • All Python code must formatted using Black, and clean from pep8 and isort issues.
  • JavaScript code should adhere to StandardJS.
  • If your changes are significant, please update ChangeLog.rst.
  • If your change is substantial, feel free to add yourself to AUTHORS.

Provider Specifics

In case you add a new provider:

  • Make sure unit tests are available.
  • Add an entry of your provider in test_settings.py::INSTALLED_APPS and docs/installation.rst::INSTALLED_APPS.
  • Add documentation to docs/providers/<provider name>.rst and docs/providers/index.rst Provider Specifics toctree.
  • Add an entry to the list of supported providers over at docs/overview.rst.

For cyrillic names on social accounts - the encode and decode operations result in replacing all chars with empty string. And later in try-except block clean_username does not raise a ValidationError, so empty string username is considered valid. As a result, "user" is returned at first iteration and other txts are not even being processed
@coveralls
Copy link

Coverage Status

coverage: 95.895% (+0.001%) from 95.894%
when pulling 47167eb on Nazarinh0:patch-2
into bd7b69f on pennersr:main.

@pennersr pennersr merged commit 8afc3a6 into pennersr:main Feb 28, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants