Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For cyrillic names on social accounts - the encode and decode operations result in replacing all chars with empty string. And later in try-except block clean_username does not raise a ValidationError, so empty string username is considered valid. As a result, "user" is returned at first iteration and other txts are not even being processed. For example, I have last name, email, username on my social account, which is in latin alphabet and would be suitable for use as a username, I still will be called "user" because of cyrillic name. This issue may affect all non-latin names or last names including russian, chinese, arabic and so on.
Submitting Pull Requests
General
Examples:
"fix(google): Fixed foobar bug"
,"feat(accounts): Added foobar feature"
.ChangeLog.rst
.AUTHORS
.Provider Specifics
In case you add a new provider:
test_settings.py::INSTALLED_APPS
anddocs/installation.rst::INSTALLED_APPS
.docs/providers/<provider name>.rst
anddocs/providers/index.rst
Provider Specifics toctree.docs/overview.rst
.