fix(socialaccount): Allow account connections page to establish SITE_ID from request

[jeredfloyd]

Similar to the fix in #3548 , the subprovider refactoring in 0.55 created the necessity to identity SITE_ID based on the request in get_provider_account, which is used in the Django template for the Account Connections page.

This was the simplest way I could find to resolve the problem and get this page working again. I know next to nothing about Django, so I'm open to feedback. This and the previous PR may indicate a systemic challenge with the subprovider implementation that may require a different refactoring if related issues arise in the future.

[pennersr]

Can you show me the full stacktrace of the ImproperlyConfigured exception? Because likely, a simpler solution is to replace this:

Site.objects.get_current()

with:

from allauth.core import context
Site.objects.get_current(context.request)

[jeredfloyd]

That would be a simpler fix if it works (I will test)...

Here is the backtrace:

Traceback (most recent call last):
  File "/opt/app-root/src/.local/lib/python3.9/site-packages/django/core/handlers/exception.py", line 56, in inner
    response = get_response(request)
  File "/opt/app-root/src/.local/lib/python3.9/site-packages/django/core/handlers/base.py", line 220, in _get_response
    response = response.render()
  File "/opt/app-root/src/.local/lib/python3.9/site-packages/django/template/response.py", line 114, in render
    self.content = self.rendered_content
  File "/opt/app-root/src/.local/lib/python3.9/site-packages/django/template/response.py", line 92, in rendered_content
    return template.render(context, self._request)
  File "/opt/app-root/src/.local/lib/python3.9/site-packages/django/template/backends/django.py", line 61, in render
    return self.template.render(context)
  File "/opt/app-root/src/.local/lib/python3.9/site-packages/django/template/base.py", line 175, in render
    return self._render(context)
  File "/opt/app-root/src/.local/lib/python3.9/site-packages/django/template/base.py", line 167, in _render
    return self.nodelist.render(context)
  File "/opt/app-root/src/.local/lib/python3.9/site-packages/django/template/base.py", line 1005, in render
    return SafeString("".join([node.render_annotated(context) for node in self]))
  File "/opt/app-root/src/.local/lib/python3.9/site-packages/django/template/base.py", line 1005, in <listcomp>
    return SafeString("".join([node.render_annotated(context) for node in self]))
  File "/opt/app-root/src/.local/lib/python3.9/site-packages/django/template/base.py", line 966, in render_annotated
    return self.render(context)
  File "/opt/app-root/src/.local/lib/python3.9/site-packages/django/template/loader_tags.py", line 157, in render
    return compiled_parent._render(context)
  File "/opt/app-root/src/.local/lib/python3.9/site-packages/django/template/base.py", line 167, in _render
    return self.nodelist.render(context)
  File "/opt/app-root/src/.local/lib/python3.9/site-packages/django/template/base.py", line 1005, in render
    return SafeString("".join([node.render_annotated(context) for node in self]))
  File "/opt/app-root/src/.local/lib/python3.9/site-packages/django/template/base.py", line 1005, in <listcomp>
    return SafeString("".join([node.render_annotated(context) for node in self]))
  File "/opt/app-root/src/.local/lib/python3.9/site-packages/django/template/base.py", line 966, in render_annotated
    return self.render(context)
  File "/opt/app-root/src/.local/lib/python3.9/site-packages/django/template/loader_tags.py", line 157, in render
    return compiled_parent._render(context)
  File "/opt/app-root/src/.local/lib/python3.9/site-packages/django/template/base.py", line 167, in _render
    return self.nodelist.render(context)
  File "/opt/app-root/src/.local/lib/python3.9/site-packages/django/template/base.py", line 1005, in render
    return SafeString("".join([node.render_annotated(context) for node in self]))
  File "/opt/app-root/src/.local/lib/python3.9/site-packages/django/template/base.py", line 1005, in <listcomp>
    return SafeString("".join([node.render_annotated(context) for node in self]))
  File "/opt/app-root/src/.local/lib/python3.9/site-packages/django/template/base.py", line 966, in render_annotated
    return self.render(context)
  File "/opt/app-root/src/.local/lib/python3.9/site-packages/django/template/loader_tags.py", line 157, in render
    return compiled_parent._render(context)
  File "/opt/app-root/src/.local/lib/python3.9/site-packages/django/template/base.py", line 167, in _render
    return self.nodelist.render(context)
  File "/opt/app-root/src/.local/lib/python3.9/site-packages/django/template/base.py", line 1005, in render
    return SafeString("".join([node.render_annotated(context) for node in self]))
  File "/opt/app-root/src/.local/lib/python3.9/site-packages/django/template/base.py", line 1005, in <listcomp>
    return SafeString("".join([node.render_annotated(context) for node in self]))
  File "/opt/app-root/src/.local/lib/python3.9/site-packages/django/template/base.py", line 966, in render_annotated
    return self.render(context)
  File "/opt/app-root/src/.local/lib/python3.9/site-packages/django/template/loader_tags.py", line 63, in render
    result = block.nodelist.render(context)
  File "/opt/app-root/src/.local/lib/python3.9/site-packages/django/template/base.py", line 1005, in render
    return SafeString("".join([node.render_annotated(context) for node in self]))
  File "/opt/app-root/src/.local/lib/python3.9/site-packages/django/template/base.py", line 1005, in <listcomp>
    return SafeString("".join([node.render_annotated(context) for node in self]))
  File "/opt/app-root/src/.local/lib/python3.9/site-packages/django/template/base.py", line 966, in render_annotated
    return self.render(context)
  File "/opt/app-root/src/.local/lib/python3.9/site-packages/django/template/loader_tags.py", line 63, in render
    result = block.nodelist.render(context)
  File "/opt/app-root/src/.local/lib/python3.9/site-packages/django/template/base.py", line 1005, in render
    return SafeString("".join([node.render_annotated(context) for node in self]))
  File "/opt/app-root/src/.local/lib/python3.9/site-packages/django/template/base.py", line 1005, in <listcomp>
    return SafeString("".join([node.render_annotated(context) for node in self]))
  File "/opt/app-root/src/.local/lib/python3.9/site-packages/django/template/base.py", line 966, in render_annotated
    return self.render(context)
  File "/opt/app-root/src/.local/lib/python3.9/site-packages/django/template/defaulttags.py", line 321, in render
    return nodelist.render(context)
  File "/opt/app-root/src/.local/lib/python3.9/site-packages/django/template/base.py", line 1005, in render
    return SafeString("".join([node.render_annotated(context) for node in self]))
  File "/opt/app-root/src/.local/lib/python3.9/site-packages/django/template/base.py", line 1005, in <listcomp>
    return SafeString("".join([node.render_annotated(context) for node in self]))
  File "/opt/app-root/src/.local/lib/python3.9/site-packages/django/template/base.py", line 966, in render_annotated
    return self.render(context)
  File "/opt/app-root/src/.local/lib/python3.9/site-packages/django/template/defaulttags.py", line 238, in render
    nodelist.append(node.render_annotated(context))
  File "/opt/app-root/src/.local/lib/python3.9/site-packages/django/template/base.py", line 966, in render_annotated
    return self.render(context)
  File "/opt/app-root/src/.local/lib/python3.9/site-packages/django/template/defaulttags.py", line 539, in render
    values = {key: val.resolve(context) for key, val in self.extra_context.items()}
  File "/opt/app-root/src/.local/lib/python3.9/site-packages/django/template/defaulttags.py", line 539, in <dictcomp>
    values = {key: val.resolve(context) for key, val in self.extra_context.items()}
  File "/opt/app-root/src/.local/lib/python3.9/site-packages/django/template/base.py", line 715, in resolve
    obj = self.var.resolve(context)
  File "/opt/app-root/src/.local/lib/python3.9/site-packages/django/template/base.py", line 847, in resolve
    value = self._resolve_lookup(context)
  File "/opt/app-root/src/.local/lib/python3.9/site-packages/django/template/base.py", line 914, in _resolve_lookup
    current = current()
  File "/opt/app-root/src/.local/lib/python3.9/site-packages/allauth/socialaccount/models.py", line 147, in get_provider_account
    return self.get_provider().wrap_account(self)
  File "/opt/app-root/src/.local/lib/python3.9/site-packages/allauth/socialaccount/models.py", line 141, in get_provider
    provider = self._provider = adapter.get_provider(
  File "/opt/app-root/src/.local/lib/python3.9/site-packages/allauth/socialaccount/adapter.py", line 204, in get_provider
    app = self.get_app(request, provider=provider)
  File "/opt/app-root/src/.local/lib/python3.9/site-packages/allauth/socialaccount/adapter.py", line 284, in get_app
    apps = self.list_apps(request, provider=provider, client_id=client_id)
  File "/opt/app-root/src/.local/lib/python3.9/site-packages/allauth/socialaccount/adapter.py", line 231, in list_apps
    db_apps = SocialApp.objects.on_site(request)
  File "/opt/app-root/src/.local/lib/python3.9/site-packages/allauth/socialaccount/models.py", line 27, in on_site
    site = get_current_site(request)
  File "/opt/app-root/src/.local/lib/python3.9/site-packages/django/contrib/sites/shortcuts.py", line 16, in get_current_site
    return Site.objects.get_current(request)
  File "/opt/app-root/src/.local/lib/python3.9/site-packages/django/contrib/sites/models.py", line 63, in get_current
    raise ImproperlyConfigured(

Exception Type: ImproperlyConfigured at /accounts/social/connections/
Exception Value: You're using the Django "sites framework" without having set the SITE_ID setting. Create a site in your database and set the SITE_ID setting or pass a request to Site.objects.get_current() to fix this error.
Raised during: allauth.socialaccount.views.ConnectionsView

[jeredfloyd]

Yes; there is a 1-line fix that is easier. I'll suggest that instead.

[pennersr]

Thanks. Assuming this also fixes the previous issue, can you include a revert of those changes as well?

[jeredfloyd]

It does not fix the previous issue -- they are separate functions.