Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): Build broken libgnutlsxx not found #3539

Merged
merged 2 commits into from
Nov 27, 2023
Merged

fix(ci): Build broken libgnutlsxx not found #3539

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b49d3b1
fix(ci): Build broken libgnutlsxx not found
pennersr Nov 27, 2023
fa223c6
tests(mfa): assertFormError vs __all__
pennersr Nov 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,8 @@ jobs:
uses: actions/setup-python@v4
with:
python-version: ${{ matrix.python-version }}
- name: Updating package list
run: sudo apt-get update
- name: Install xmlsec
run: sudo apt-get install -y xmlsec1 libxmlsec1-dev
- name: Install dependencies
Expand Down
18 changes: 6 additions & 12 deletions allauth/mfa/tests/test_views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,18 +231,12 @@ def test_cannot_deactivate_totp(auth_client, user_with_totp, user_password):
assert resp.status_code == 302
resp = auth_client.get(reverse("mfa_deactivate_totp"))
# When we GET, the form validation error is already on screen
assertFormError(
resp,
"form",
"__all__",
get_adapter().error_messages["cannot_delete_authenticator"],
)
assert resp.context["form"].errors == {
"__all__": [get_adapter().error_messages["cannot_delete_authenticator"]],
}
# And, when we POST anyway, it does not work
resp = auth_client.post(reverse("mfa_deactivate_totp"))
assert resp.status_code == 200
assertFormError(
resp,
"form",
"__all__",
get_adapter().error_messages["cannot_delete_authenticator"],
)
assert resp.context["form"].errors == {
"__all__": [get_adapter().error_messages["cannot_delete_authenticator"]],
}