EMAIL_AUTHENTICATION_AUTO_CONNECT

[yashar-vasegh]

Hi,

I am facing problem to solve a problem. Here is the scenario, user is created in django users model and on first sso login I want to connect the user, so I added this

`
def pre_social_login(self, request, sociallogin):
if sociallogin.is_existing:
return

if not sociallogin.email_addresses:
    return

email = sociallogin.email_addresses[0].email
if not email:
    print("No email found on sso data!")
    return

try:
    user = User.objects.get(email=email)
except User.DoesNotExist:
    return

if user:
    sociallogin.state['process'] = 'connect'
    print(f"connecting new user sso {user}....")
    sociallogin.connect(request, user)

`

then I get this error when user try to login,
Object of type AppConfigData is not JSON serializable Traceback (most recent call last): File "/usr/local/lib/python3.11/site-packages/rest_framework/views.py", line 506, in dispatch response = handler(request, *args, **kwargs) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.11/site-packages/dj_rest_auth/views.py", line 125, in post self.serializer.is_valid(raise_exception=True) File "/usr/local/lib/python3.11/site-packages/rest_framework/serializers.py", line 227, in is_valid self._validated_data = self.run_validation(self.initial_data) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.11/site-packages/rest_framework/serializers.py", line 429, in run_validation value = self.validate(value) ^^^^^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.11/site-packages/dj_rest_auth/registration/serializers.py", line 161, in validate ret = complete_social_login(request, login) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.11/site-packages/allauth/socialaccount/helpers.py", line 209, in complete_social_login return _complete_social_login(request, sociallogin) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.11/site-packages/allauth/socialaccount/helpers.py", line 227, in _complete_social_login ret = _process_signup(request, sociallogin) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.11/site-packages/allauth/socialaccount/helpers.py", line 70, in _process_signup request.session["socialaccount_sociallogin"] = sociallogin.serialize() ^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.11/site-packages/allauth/socialaccount/models.py", line 221, in serialize user=serialize_instance(self.user), ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.11/site-packages/allauth/socialaccount/adapter.py", line 174, in serialize_instance return serialize_instance(instance) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.11/site-packages/allauth/utils.py", line 186, in serialize_instance return json.loads(json.dumps(data, cls=DjangoJSONEncoder)) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.11/json/init.py", line 238, in dumps **kw).encode(obj) ^^^^^^^^^^^ File "/usr/local/lib/python3.11/json/encoder.py", line 200, in encode chunks = self.iterencode(o, _one_shot=True) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.11/json/encoder.py", line 258, in iterencode return _iterencode(o, 0) ^^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.11/site-packages/django/core/serializers/json.py", line 106, in default return super().default(o) ^^^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.11/json/encoder.py", line 180, in default raise TypeError(f'Object of type {o.class.name} ' TypeError: Object of type AppConfigData is not JSON serializable

So I trace back the code and I found EMAIL_AUTHENTICATION_AUTO_CONNECT, and I set that, but I am still getting the same error.

I am filling I am missing what is happening through connect, because if I remove the created user in db and go through sso process it is working but when user is created in advance it is failing to login and connect as I paste the error.

Would appreciate your help.

Yashar.

[yashar-vasegh]

Here is what I did to solve it,

lets first see the error, so for the first login the code falls into ret = _process_signup(request, sociallogin)

def _complete_social_login(request, sociallogin): if request.user.is_authenticated: get_account_adapter(request).logout(request) if sociallogin.is_existing: # Login existing user ret = _login_social_account(request, sociallogin) else: # New social user ret = _process_signup(request, sociallogin) return ret

to pass redirect to signup in def _process_signup(request, sociallogin), I set ACCOUNT_PREVENT_ENUMERATION = "strict" in settings, then I override the save function to prevent create duplicate users in django user db, This is not a good solution but this is the only way I found to cover all cases,

`
class SocialAccountAdapter(DefaultSocialAccountAdapter):
def is_open_for_signup(self, request: HttpRequest, sociallogin: Any):
return getattr(settings, "ACCOUNT_ALLOW_REGISTRATION", True)

def find_matching_user(self, sociallogin):
    if not sociallogin.email_addresses:
        print("no email address")
        return

    email = sociallogin.email_addresses[0].email
    if not email:
        print("No email found on sso data!")
        return

    try:
        user = User.objects.get(email__iexact=email)
    except:
        print(f"user not found or multi user found, {email}")
        return

    return user

def save_user(self, request, sociallogin, form=None):
    """
    Saves a newly signed up social login. In case of auto-signup,
    the signup form is not available.
    """
    print("calling presave!")
    user = self.find_matching_user(sociallogin)
    if user:
        sociallogin.user = user
    u = sociallogin.user

    if not user:
        u.set_unusable_password()
        if form:
            get_account_adapter().save_user(request, u, form)
        else:
            get_account_adapter().populate_username(request, u)
        sociallogin.save(request)
    else:
        sociallogin.save(request, True)
    return u

def pre_social_login(self, request, sociallogin):
    print("calling pre social login")
    if sociallogin.is_existing:
        print("exsisting...")
        return

    user = self.find_matching_user(sociallogin)

    if user:
        sociallogin.state['process'] = 'connect'
        print(f"connecting new user sso {user}....")
        sociallogin.connect(request, user)

`

it is working, but I dont like it at all!

[yashar-vasegh]

Anyone has better solution?

[yashar-vasegh]

I am trying to do the exact thing, those variables are set but it didn't work.

right now my solution is working but I had to set ACCOUNT_PREVENT_ENUMERATION = "strict" which is not good.

I will look into is_email_verified, might be related to that, in that case that will be great.

Thank you.

[pennersr]

Email authentication is only enabled when the email address as retrieved from the provider is marked as verified, otherwise an untrustworthy provider could be abused to hijack any local user account.

[colmmcmullan]

I'm struggling with this as well. I have configured the three settings as documented (see shell output below) and am not using any custom adapters.

The behaviour I see is:

1. SSO signup for a new account: works as expected
2. SSO login to an account that has a Connected Account: works as expected
3. SSO signup or login for an email address that exists on an account and that does not have a Connected Account: redirects back to the signup page. My expectation is that it should automatically connect the account and log the user in.

You can test this at https://my.live-footballontv.com/accounts/signup/ by creating an account using an email address, then trying to use either Google or Apple SSO for the same email address.

Settings:

root@e259d1a612a4:/lfotv# django-admin shell
Python 3.8.10 (default, Nov 22 2023, 10:22:35) 
[GCC 9.4.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
(InteractiveConsole)
>>> from django.conf import settings
>>> print(settings.SOCIALACCOUNT_EMAIL_AUTHENTICATION)
True
>>> print(settings.SOCIALACCOUNT_EMAIL_AUTHENTICATION_AUTO_CONNECT)
True
>>> print(settings.SOCIALACCOUNT_PROVIDERS["apple"]["VERIFIED_EMAIL"])
True
>>> print(settings.SOCIALACCOUNT_PROVIDERS["google"]["VERIFIED_EMAIL"])
True

I would welcome any suggestions you can offer.

[pennersr]

Those settings look fine. What version of allauth are you using? If the latest, then I don't have an explanation why it is not working for you. Please try stepping through...

https://github.com/pennersr/django-allauth/blob/main/allauth/socialaccount/models.py#L373

... to see why it is not working.

[colmmcmullan]

Ah - upgrading the version of allauth fixed it. Thanks for the reply!