tests: It is deprecated to return a value that is not None

pennersr · Sep 20, 2024 · 00f313a · 00f313a
1 parent 7080853
commit 00f313a
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 5 deletions.
diff --git a/allauth/socialaccount/providers/flickr/tests.py b/allauth/socialaccount/providers/flickr/tests.py
@@ -1,3 +1,4 @@
+from allauth.socialaccount.models import SocialAccount
 from allauth.socialaccount.tests import OAuthTestsMixin
 from allauth.tests import MockedResponse, TestCase
 
@@ -47,7 +48,8 @@ def get_expected_to_str(self):
         return "pennersr"
 
     def test_login(self):
-        account = super(FlickrTests, self).test_login()
+        super().test_login()
+        account = SocialAccount.objects.get(uid="12345678@N00")
         f_account = account.get_provider_account()
         self.assertEqual(account.user.first_name, "raymond")
         self.assertEqual(account.user.last_name, "penners")
@@ -103,7 +105,8 @@ def get_expected_to_str(self):
         return "pennersr"
 
     def test_login(self):
-        account = super(FlickrWithoutRealNameTests, self).test_login()
+        super().test_login()
+        account = SocialAccount.objects.get(uid="12345678@N00")
         f_account = account.get_provider_account()
         self.assertEqual(account.user.first_name, "")
         self.assertEqual(account.user.last_name, "")

diff --git a/allauth/socialaccount/providers/openstreetmap/tests.py b/allauth/socialaccount/providers/openstreetmap/tests.py
@@ -1,3 +1,4 @@
+from allauth.socialaccount.models import SocialAccount
 from allauth.socialaccount.tests import OAuthTestsMixin
 from allauth.tests import MockedResponse, TestCase
 
@@ -34,7 +35,8 @@ def get_expected_to_str(self):
         return "Steve"
 
     def test_login(self):
-        account = super(OpenStreetMapTests, self).test_login()
+        super().test_login()
+        account = SocialAccount.objects.get(uid="1")
         osm_account = account.get_provider_account()
         self.assertEqual(osm_account.get_username(), "Steve")
         self.assertEqual(

diff --git a/allauth/socialaccount/providers/twitter/tests.py b/allauth/socialaccount/providers/twitter/tests.py
@@ -1,3 +1,4 @@
+from allauth.socialaccount.models import SocialAccount
 from allauth.socialaccount.tests import OAuthTestsMixin
 from allauth.tests import MockedResponse, TestCase
 
@@ -31,7 +32,8 @@ def get_expected_to_str(self):
         return "pennersr"
 
     def test_login(self):
-        account = super(TwitterTests, self).test_login()
+        super().test_login()
+        account = SocialAccount.objects.get(uid="45671919")
         tw_account = account.get_provider_account()
         self.assertEqual(tw_account.get_screen_name(), "pennersr")
         self.assertEqual(

diff --git a/allauth/socialaccount/tests/__init__.py b/allauth/socialaccount/tests/__init__.py
@@ -84,7 +84,6 @@ def test_login(self):
         provider_account.get_avatar_url()
         provider_account.get_profile_url()
         provider_account.get_brand()
-        return account
 
     @override_settings(
         SOCIALACCOUNT_AUTO_SIGNUP=True,