metadata: validate min chunk length for jpeg #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sscobici
force-pushed
the
metadata-fix
branch
2 times, most recently
from
9015455 to
c5b3540
Compare
pdeljanov
requested changes
Jan 18, 2025
Comment on lines
85
to
87
| if chunk_len < 2 { | ||
| return decode_error("meta (jpeg): invalid chunk length"); | ||
| } |
There was a problem hiding this comment.
Looking further into JPEG, it looks like there are some chunks that don't actually have a length (they're just markers essentially) 1. These are chunk_types 0xd0 to 0xd9, inclusive.
After line 66, can you add a continue if any of these chunk types are encountered?
Then, please move this check to after line 67 where chunk_len is read, since a length < 2 is just invalid entirely.
Footnotes
sscobici
force-pushed
the
metadata-fix
branch
from
c5b3540 to
e921f6f
Compare
|
fixed |
pdeljanov
approved these changes
Jan 18, 2025
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes panic