Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow use of custom HttpClient #9

Open
tzifudzi opened this issue May 16, 2019 · 1 comment
Open

Allow use of custom HttpClient #9

tzifudzi opened this issue May 16, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@tzifudzi
Copy link
Collaborator

As raised by @bmukokera in the Paynow developer forum, an SDK should follow SOLID principles and hence be easy to extend. Currently, the SDK uses an open source HttpClient from the Apache library and this cannot be changed without recompiling the original source code.

The SDK needs to be refactored to allow for use with a custom HttpClient. @bmukokera If you are still willing to take it up may I proceed to assign you the task? We currently do not have a set of contributing guidelines so I would suggest you just create a develop branch and make a pull request into master.
@tzifudzi tzifudzi added the enhancement New feature or request label May 16, 2019
@bmukorera
Copy link

That will great, will make time for this and work on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bmukorera @tzifudzi