FISH-10319 Add create-jvm-option command #7139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pandrex247
approved these changes
Jan 10, 2025
nucleus/core/kernel/src/main/manpages/fish/payara/enterprise/admin/commands/create-jvm-option.1
Outdated
Show resolved
Hide resolved
| throw new IllegalArgumentException(msg); | ||
| } | ||
| if (bag.contains(option)) { | ||
| // setting an option that already exists is considered an error |
There was a problem hiding this comment.
Probably outside the scope of this issue, but this doesn't seem to work unless the string matches exactly.
For example:
asadmin create-jvm-option -XX:MaxPermSize=512m
Successfully added JVM option: -XX:MaxPermSize=512m
asadmin create-jvm-option -XX:MaxPermSize=513m
Successfully added JVM option: -XX:MaxPermSize=513m
-XX:MaxPermSize=513m
remote failure: JVM option -XX:MaxPermSize=513m already exists in the configuration.
Co-authored-by: Andrew Pielage <pandrex247@hotmail.com>
|
Code freeze missed, do not merge until RC cut |
|
New RCs will be cut |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
create-jvm-optionasadmin command.Important Info
Blockers
Testing
New tests
Testing Performed
Used the command to create a new JVM option, verified the existence of the new option via the
list-jvm-optionscommand.Testing Environment
Maven version: 3.9.6
Java version: 11.0.23, vendor: Eclipse Adoptium
Default locale: en_GB, platform encoding: Cp1252
OS name: "windows 11", version: "10.0", arch: "amd64", family: "windows"
Documentation
Notes for Reviewers