Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address clang tidy warnings #87

Merged
merged 38 commits into from
Dec 16, 2023
Merged

Address clang tidy warnings #87

merged 38 commits into from
Dec 16, 2023

Conversation

robomics
Copy link
Contributor

@robomics robomics commented Dec 14, 2023

Address new warnings raised by clang-tidy-17.

Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (69c7017) 84.74% compared to head (fc352ca) 84.75%.

Files Patch % Lines
...ooler/include/hictk/cooler/impl/attribute_impl.hpp 80.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #87   +/-   ##
=======================================
  Coverage   84.74%   84.75%           
=======================================
  Files         101      101           
  Lines        7318     7319    +1     
=======================================
+ Hits         6202     6203    +1     
  Misses       1116     1116           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robomics robomics merged commit de94e65 into main Dec 16, 2023
50 checks passed
@robomics robomics deleted the lint/clang-tidy branch December 16, 2023 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant