-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support variable bin sizes #81
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
robomics
commented
Dec 6, 2023
•
edited
Loading
edited
- Rename BinTable to BinTableFixed
- Implement BinTableVariable to support operating on tables with variable bin size
- BinTable is now a wrapper around BinTableFixed and BinTableVariable
- Update Reference to store the prefix sum of the chromosome sizes
- Fix minor bug in Reference ctor when constructing reference from iterators of chromosomes
- Update hictk load to support loading interactions using tables of variable bin size
- Update hictk merge to support merging interactions using tables of variable bin size
- Rename BinTable to BinTableFixed - Implement BinTableVariable to support operating on tables with variable bin size - BinTable is now a wrapper around BinTableFixed and BinTableVariable - Update Reference to stor the prefix sum of the chromosome sizes - Fix minor bug in Reference ctor when constructing reference from iterators of chromosomes
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #81 +/- ##
==========================================
+ Coverage 83.65% 83.92% +0.27%
==========================================
Files 91 96 +5
Lines 6742 7111 +369
==========================================
+ Hits 5640 5968 +328
- Misses 1102 1143 +41 ☔ View full report in Codecov by Sentry. |
robomics
changed the title
Refactor BinTable and initial implementation of BinTableVariable
Support variable bin sizes
Dec 6, 2023
- Simplify PairsAggregator - Drop optimization for ingesting pre-sorted pairs (it never worked as intended) - Add --one-based and --zero-based CLI options - Improve logging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.