Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hictk dump to support dumping resolutions, cells and normalizations #62

Merged
merged 7 commits into from
Sep 27, 2023

Conversation

robomics
Copy link
Contributor

@robomics robomics commented Sep 17, 2023

No description provided.

@codecov
Copy link

codecov bot commented Sep 17, 2023

Codecov Report

Merging #62 (9bc7525) into main (d4eb1bc) will increase coverage by 0.27%.
Report is 3 commits behind head on main.
The diff coverage is 86.06%.

❗ Current head 9bc7525 differs from pull request most recent head 89b2c6d. Consider uploading reports for the commit 89b2c6d to get more accurate results

@@            Coverage Diff             @@
##             main      #62      +/-   ##
==========================================
+ Coverage   82.29%   82.56%   +0.27%     
==========================================
  Files          81       81              
  Lines        5586     5674      +88     
==========================================
+ Hits         4597     4685      +88     
  Misses        989      989              
Files Coverage Δ
src/hictk/cli/cli_validate.cpp 100.00% <ø> (ø)
...rc/libhictk/cooler/include/hictk/cooler/cooler.hpp 100.00% <ø> (ø)
.../include/hictk/cooler/impl/file_accessors_impl.hpp 87.67% <100.00%> (+1.51%) ⬆️
...ooler/include/hictk/cooler/impl/file_read_impl.hpp 73.98% <100.00%> (ø)
...clude/hictk/cooler/impl/singlecell_cooler_impl.hpp 94.25% <100.00%> (+0.03%) ⬆️
src/libhictk/file/include/hictk/impl/file_impl.hpp 100.00% <100.00%> (ø)
...tk/hic/include/hictk/hic/impl/file_reader_impl.hpp 83.67% <100.00%> (-0.21%) ⬇️
src/hictk/include/hictk/tools/cli.hpp 54.16% <62.50%> (+1.66%) ⬆️
src/hictk/cli/cli_dump.cpp 84.81% <73.68%> (+1.24%) ⬆️
src/hictk/dump/dump.cpp 71.97% <88.88%> (+15.79%) ⬆️

... and 5 files with indirect coverage changes

@robomics robomics closed this Sep 24, 2023
@robomics robomics reopened this Sep 24, 2023
@robomics robomics merged commit cac5aa5 into main Sep 27, 2023
45 checks passed
@robomics robomics deleted the improve-dump branch September 27, 2023 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant