Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hictk: support replaying warnings right before app exit #313

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

robomics
Copy link
Contributor

@robomics robomics commented Nov 6, 2024

No description provided.

@robomics robomics added the enhancement New feature or request label Nov 6, 2024
@robomics robomics force-pushed the feature/improve-logging branch from 4574105 to a3bc77e Compare November 6, 2024 20:56
@robomics robomics changed the title hcitk: support replaying warnings right before app exit hictk: support replaying warnings right before app exit Nov 6, 2024
@robomics robomics force-pushed the feature/improve-logging branch 6 times, most recently from 4ed3ea0 to 9c6814b Compare November 7, 2024 01:06
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 61.34969% with 63 lines in your changes missing coverage. Please review.

Project coverage is 77.54%. Comparing base (da6732a) to head (cec303a).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/hictk/main.cpp 66.20% 40 Missing and 9 partials ⚠️
src/hictk/cli/cli_fix_mcool.cpp 0.00% 5 Missing ⚠️
src/hictk/cli/cli_dump.cpp 0.00% 4 Missing ⚠️
src/hictk/cli/cli.cpp 50.00% 2 Missing and 1 partial ⚠️
src/hictk/cli/cli_load.cpp 0.00% 1 Missing ⚠️
src/hictk/cli/cli_zoomify.cpp 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #313   +/-   ##
=======================================
  Coverage   77.54%   77.54%           
=======================================
  Files         173      173           
  Lines       21225    21319   +94     
  Branches     2310     2315    +5     
=======================================
+ Hits        16458    16532   +74     
- Misses       3756     3779   +23     
+ Partials     1011     1008    -3     
Flag Coverage Δ
[tests integration](https://app.codecov.io/gh/paulsengroup/hictk/pull/313/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=paulsengroup) 68.01% <61.34%> (+0.03%)
[tests unittests](https://app.codecov.io/gh/paulsengroup/hictk/pull/313/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=paulsengroup) 75.95% <ø> (+0.05%)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robomics robomics force-pushed the feature/improve-logging branch from 9c6814b to cec303a Compare November 7, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant