Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hictk dump -t bins for files in .scool format #114

Merged
merged 2 commits into from
Feb 11, 2024

Conversation

robomics
Copy link
Contributor

Closes #112

Copy link

codecov bot commented Feb 11, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (082348e) 84.66% compared to head (68d660b) 84.64%.
Report is 2 commits behind head on main.

Files Patch % Lines
src/hictk/cli/cli_dump.cpp 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #114      +/-   ##
==========================================
- Coverage   84.66%   84.64%   -0.03%     
==========================================
  Files         114      114              
  Lines        9125     9130       +5     
==========================================
+ Hits         7726     7728       +2     
- Misses       1399     1402       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robomics robomics merged commit c7dd36f into main Feb 11, 2024
48 of 50 checks passed
@robomics robomics deleted the fix/hitk-dump-bins-scool branch February 11, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix hictk dump -t bins when file is in .scool format
1 participant