Merge pull request #72 from paulsengroup/bugfix

Fix segfault
paulsengroup · Oct 1, 2023 · c3cc077 · c3cc077
2 parents dc02eb7 + df827a6
commit c3cc077
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/src/libhictk/cooler/include/hictk/cooler/impl/multires_cooler_impl.hpp b/src/libhictk/cooler/include/hictk/cooler/impl/multires_cooler_impl.hpp
@@ -163,7 +163,7 @@ inline MultiResFile::operator bool() const noexcept { return !!_root_grp; }
 inline std::string MultiResFile::path() const { return (*_root_grp)().getFile().getName(); }
 
 inline auto MultiResFile::chromosomes() const noexcept -> const Reference& {
-  return open(_resolutions.back()).chromosomes();
+  return _chroms;
 }
 
 [[nodiscard]] inline std::uint32_t MultiResFile::compute_base_resolution(

diff --git a/test/units/cooler/multires_cooler_test.cpp b/test/units/cooler/multires_cooler_test.cpp
@@ -19,6 +19,8 @@ TEST_CASE("MultiResCooler: open read-only", "[cooler][short]") {
 
   auto mclr = MultiResFile(path.string());
 
+  CHECK(mclr.chromosomes().size() == 20);
+  CHECK(mclr.chromosomes().begin()->name() == "1");
   CHECK(mclr.resolutions().size() == 7);
   CHECK(mclr.attributes().format == MCOOL_MAGIC);
   CHECK(mclr.attributes().format_version == 2);