From 80965a7f01cbbe58e24b8e2bd2093752bb8300ea Mon Sep 17 00:00:00 2001 From: Roberto Rossini <71787608+robomics@users.noreply.github.com> Date: Fri, 8 Dec 2023 14:48:55 +0100 Subject: [PATCH] Address clang-tidy warnings --- test/units/cooler/file_ctors_test.cpp | 4 ++-- test/units/cooler/file_pixels_test.cpp | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/test/units/cooler/file_ctors_test.cpp b/test/units/cooler/file_ctors_test.cpp index e8febbb8..bd99cd95 100644 --- a/test/units/cooler/file_ctors_test.cpp +++ b/test/units/cooler/file_ctors_test.cpp @@ -24,7 +24,7 @@ TEST_CASE("Cooler: init files", "[cooler][short]") { std::ignore = File::create(path.string(), chroms, bin_size, true); CHECK(utils::is_cooler(path.string())); // NOLINTNEXTLINE CHECK(File(path.string()).attributes().generated_by->find("hictk") == 0); - CHECK(File(path.string()).attributes().bin_type.value() == "fixed"); + CHECK(File(path.string()).attributes().bin_type.value() == "fixed"); // NOLINT } SECTION("variable bins") { @@ -41,7 +41,7 @@ TEST_CASE("Cooler: init files", "[cooler][short]") { std::ignore = File::create(path.string(), table, true); CHECK(utils::is_cooler(path.string())); // NOLINTNEXTLINE CHECK(File(path.string()).attributes().generated_by->find("hictk") == 0); - CHECK(File(path.string()).attributes().bin_type.value() == "variable"); + CHECK(File(path.string()).attributes().bin_type.value() == "variable"); // NOLINT } } diff --git a/test/units/cooler/file_pixels_test.cpp b/test/units/cooler/file_pixels_test.cpp index 9d224836..6f9d3b1a 100644 --- a/test/units/cooler/file_pixels_test.cpp +++ b/test/units/cooler/file_pixels_test.cpp @@ -29,7 +29,7 @@ TEST_CASE("Cooler: read/write pixels", "[cooler][long]") { std::mt19937_64 rand_eng{rd()}; auto pixel_it = expected.begin(); - do { + do { // NOLINT(cppcoreguidelines-avoid-do-while) const auto diff = std::distance(pixel_it, expected.end()); // Write pixels in chunks of random size const auto offset =