Skip to content

Commit

Permalink
Address clang-tidy warnings
Browse files Browse the repository at this point in the history
  • Loading branch information
robomics committed Dec 8, 2023
1 parent 05dc1bb commit 80965a7
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions test/units/cooler/file_ctors_test.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ TEST_CASE("Cooler: init files", "[cooler][short]") {
std::ignore = File::create(path.string(), chroms, bin_size, true);
CHECK(utils::is_cooler(path.string())); // NOLINTNEXTLINE
CHECK(File(path.string()).attributes().generated_by->find("hictk") == 0);
CHECK(File(path.string()).attributes().bin_type.value() == "fixed");
CHECK(File(path.string()).attributes().bin_type.value() == "fixed"); // NOLINT
}

SECTION("variable bins") {
Expand All @@ -41,7 +41,7 @@ TEST_CASE("Cooler: init files", "[cooler][short]") {
std::ignore = File::create(path.string(), table, true);
CHECK(utils::is_cooler(path.string())); // NOLINTNEXTLINE
CHECK(File(path.string()).attributes().generated_by->find("hictk") == 0);
CHECK(File(path.string()).attributes().bin_type.value() == "variable");
CHECK(File(path.string()).attributes().bin_type.value() == "variable"); // NOLINT
}
}

Expand Down
2 changes: 1 addition & 1 deletion test/units/cooler/file_pixels_test.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ TEST_CASE("Cooler: read/write pixels", "[cooler][long]") {
std::mt19937_64 rand_eng{rd()};

auto pixel_it = expected.begin();
do {
do { // NOLINT(cppcoreguidelines-avoid-do-while)
const auto diff = std::distance(pixel_it, expected.end());
// Write pixels in chunks of random size
const auto offset =
Expand Down

0 comments on commit 80965a7

Please sign in to comment.