fix: separate error emit args from regular emit args #1397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `unlink` and `unlinkDir` events both have known types, so this adds them to the known event map.
Separates the error event arguments from the regular event arguments. Before, we had a merged tuple of `[Path | Error, Stats?]` to account for the fact that some events can be `[Path, Stats?]` and some can be `[Error, Stats?]`. However, this results in incorrect types since nothing will ever pass `Path | Error` as a type (only one or the other). This separates them and uses a union instead, such that event handlers other than `error` only ever have a `Path`.
43081j
changed the title
unlink events
|
I got the following error after upgrading to v4.0.3 when using src/cli/index.ts:87:20 - error TS2576: Property 'on' does not exist on type 'FSWatcher'. Did you mean to access the static member 'FSWatcher.on' instead?
87 cliWatcher.on('all', async (eventName, filepath) => {
~~
src/cli/index.ts:87:37 - error TS7006: Parameter 'eventName' implicitly has an 'any' type.
87 cliWatcher.on('all', async (eventName, filepath) => {
~~~~~~~~~
src/cli/index.ts:87:48 - error TS7006: Parameter 'filepath' implicitly has an 'any' type.
87 cliWatcher.on('all', async (eventName, filepath) => {
~~~~~~~~ |
|
we haven't changed anything around that as far as i can tell. are you sure it didn't already error in 4.0.2 with and you just coincidentally upgraded both at the same time? otherwise seems pretty strange as this PR didn't touch what node types we use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separates the error event arguments from the regular event arguments.
Before, we had a merged tuple of
[Path | Error, Stats?]to account forthe fact that some events can be
[Path, Stats?]and some can be[Error, Stats?].However, this results in incorrect types since nothing will ever pass
Path | Erroras a type (only one or the other).This separates them and uses a union instead, such that event handlers
other than
erroronly ever have aPath.