Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward compatibility with future versions of JAX errors. #868

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

patrick-kidger
Copy link
Owner

No description provided.

@patrick-kidger patrick-kidger merged commit 9121934 into main Oct 1, 2024
2 checks passed
@patrick-kidger patrick-kidger deleted the 0-4-34-errors branch October 1, 2024 16:51
@hawkinsp
Copy link
Contributor

hawkinsp commented Oct 4, 2024

Thanks for doing this! I was just about to send you a PR doing the same...

except AttributeError:
try:
# Forward compatibility in case they ever decide to fix the capitalization.
JaxRuntimeError = jax.errors.JAXRuntimeError # pyright: ignore[reportAttributeAccessIssue]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, that would have been a helpful comment before I changed many users to this naming. I'm inclined to leave it as is.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha! 😄 I just spotted that the capitalisation differed as compared to the other JAX errors and erred on the side of caution. No strong opinions from me :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants