Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add detail to make_with_state doc. #846

Closed
wants to merge 1 commit into from

Conversation

garymm
Copy link
Contributor

@garymm garymm commented Sep 12, 2024

No description provided.

@patrick-kidger
Copy link
Owner

Hmm, I don't think I'm a fan of this I'm afraid. delete_init_state is deliberately not documented -- make_with_state is the 'safe' public API for this.

@garymm
Copy link
Contributor Author

garymm commented Sep 13, 2024

Thanks for taking a look.

For context I ran into this error and was confused because I had not called delete_init_state:

"Cannot call `eqx.nn.State(eqx.nn.delete_init_state(model))`. "

If you don't like this, perhaps some rewording of that error message then?

@patrick-kidger
Copy link
Owner

Sounds reasonable! I'll do that now and close this.

@garymm garymm deleted the garymm/stateful-doc branch September 14, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants