Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write a streamline_args decorator for eqx.Modules #933

Closed
johannahaffner opened this issue Jan 10, 2025 · 2 comments · Fixed by patrick-kidger/wadler_lindig#2
Closed

Write a streamline_args decorator for eqx.Modules #933

johannahaffner opened this issue Jan 10, 2025 · 2 comments · Fixed by patrick-kidger/wadler_lindig#2

Comments

@johannahaffner
Copy link

As argued in patrick-kidger/optimistix#109.

@johannahaffner
Copy link
Author

Heads up that wadler_lindig (without any changes of mine) breaks the optimistix documentation. It can't deal with certain instances of children, it works if I remove NonlinearCG, which has e.g. polak_ribiere as an attribute, and IndirectLevenbergMarquardt, which has a root finder as an attribute.

I have not figured out more yet and can't devote any time to it before the weekend at the earliest, but maybe something to keep in the back of your mind in case you were planning to do a release of equinox.

@patrick-kidger
Copy link
Owner

Ty for the report! Just fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants