Ruby - Minor QoL improvements (#38)

* Remove the ignore list in code gen * Remove unused models * Bump version * Bump ruby version and fix empty parameters * Bump version * Revert
patch-technology · Sep 1, 2021 · c8b4f10 · c8b4f10
1 parent 860631f
commit c8b4f10
Show file tree

Hide file tree

Showing 7 changed files with 32 additions and 22 deletions.
diff --git a/.ruby-version b/.ruby-version
@@ -1 +1 @@
-3.0.0
+3.0.2
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [1.10.2] - 2021-09-01
+
+### Fixed
+
+- Allows methods to be called with no parameters
+
 ## [1.10.0] - 2021-08-27
 
 ### Added

diff --git a/Gemfile.lock b/Gemfile.lock
@@ -17,7 +17,7 @@ GEM
     byebug (11.1.3)
     coderay (1.1.3)
     concurrent-ruby (1.1.9)
-    diff-lcs (1.4.3)
+    diff-lcs (1.4.4)
     ethon (0.14.0)
       ffi (>= 1.15.0)
     factory_bot (6.2.0)
@@ -31,28 +31,28 @@ GEM
     parallel (1.20.1)
     parser (3.0.2.0)
       ast (~> 2.4.1)
-    pry (0.13.1)
+    pry (0.14.1)
       coderay (~> 1.1)
       method_source (~> 1.0)
-    pry-byebug (3.9.0)
+    pry-byebug (3.8.0)
       byebug (~> 11.0)
-      pry (~> 0.13.0)
+      pry (~> 0.10)
     psych (4.0.1)
     rainbow (3.0.0)
-    rake (13.0.1)
-    rspec (3.9.0)
-      rspec-core (~> 3.9.0)
-      rspec-expectations (~> 3.9.0)
-      rspec-mocks (~> 3.9.0)
-    rspec-core (3.9.2)
-      rspec-support (~> 3.9.3)
-    rspec-expectations (3.9.2)
+    rake (13.0.6)
+    rspec (3.10.0)
+      rspec-core (~> 3.10.0)
+      rspec-expectations (~> 3.10.0)
+      rspec-mocks (~> 3.10.0)
+    rspec-core (3.10.1)
+      rspec-support (~> 3.10.0)
+    rspec-expectations (3.10.1)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.9.0)
-    rspec-mocks (3.9.1)
+      rspec-support (~> 3.10.0)
+    rspec-mocks (3.10.2)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.9.0)
-    rspec-support (3.9.3)
+      rspec-support (~> 3.10.0)
+    rspec-support (3.10.2)
     rubocop (0.66.0)
       jaro_winkler (~> 1.5.1)
       parallel (~> 1.10)
@@ -70,15 +70,16 @@ GEM
     zeitwerk (2.4.2)
 
 PLATFORMS
-  ruby
+  x86_64-darwin-20
 
 DEPENDENCIES
   factory_bot (~> 6.2)
   patch_ruby!
+  pry
   pry-byebug
   rake (~> 13.0.1)
   rspec (~> 3.6, >= 3.6.0)
   rubocop (~> 0.66.0)
 
 BUNDLED WITH
-   2.2.14
+   2.2.22
diff --git a/Makefile b/Makefile
@@ -1,8 +1,8 @@
 SHELL = /bin/bash
 
 build:
-	rubocop -a && \
-	bundle install
+	bundle install && \
+	rubocop -a
 
 test:
 	bundle exec rspec

diff --git a/patch_ruby.gemspec b/patch_ruby.gemspec
@@ -38,6 +38,7 @@ Gem::Specification.new do |s|
 
   # Start custom
   s.add_development_dependency 'factory_bot', '~> 6.2'
+  s.add_development_dependency 'pry'
   # End custom
 
 end
diff --git a/spec/integration/estimates_spec.rb b/spec/integration/estimates_spec.rb
@@ -74,8 +74,9 @@
     expect(create_estimate_response.data.mass_g).to eq 12_431
   end
 
+
   it 'supports creating bitcoin estimates with partial information' do
-    bitcoin_estimate = Patch::Estimate.create_bitcoin_estimate({ create_order: false })
+    bitcoin_estimate = Patch::Estimate.create_bitcoin_estimate({})
 
     expect(bitcoin_estimate.data.type).to eq 'bitcoin'
     expect(bitcoin_estimate.data.mass_g).to be >= 2_000

diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb
@@ -15,6 +15,7 @@
 # Start custom
 require 'constants'
 require 'factory_bot'
+require 'pry'
 # End custom
 
 # Require shared spec examples