Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Space key support for row selection in data browser #2656

Closed

Conversation

sahil-ansari01
Copy link

@sahil-ansari01 sahil-ansari01 commented Feb 11, 2025

  • Implement keyboard shortcut to select/unselect rows using Space key
  • Enable navigation and selection using arrow keys and Space
  • Improve user efficiency when reviewing and selecting multiple rows

New Pull Request Checklist

Issue Description

Implements keyboard navigation and row selection functionality in data browser tables to improve user experience and efficiency.

Closes: #2654

Approach

Added keyboard navigation and selection capabilities to enhance accessibility and user efficiency:

  1. Space Key Selection:

    • Press Space to toggle selection of the currently focused row
    • Maintains existing selection state of other rows
    • Visual feedback indicates selected state
  2. Arrow Key Navigation:

    • Up/Down arrows to move between rows
    • Maintains focus position when navigating
    • Smooth scrolling to keep focused row visible
  3. Implementation Details:

    • Added keyboard event listeners for Space and Arrow keys
    • Updated row focus and selection state management
    • Integrated with existing selection mechanisms
    • Preserved multi-select functionality with Shift+Space

TODOs before merging

  • Add unit tests for keyboard navigation handlers
  • Add integration tests for selection behavior
  • Update documentation to include keyboard shortcuts
  • Add keyboard navigation section to user guide

- Implement keyboard shortcut to select/unselect rows using Space key
- Enable navigation and selection using arrow keys and Space
- Improve user efficiency when reviewing and selecting multiple rows
Copy link

Thanks for opening this pull request!

@sahil-ansari01 sahil-ansari01 deleted the fix#2654 branch February 11, 2025 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Press space key to un-/select a row in data browser
1 participant