-
-
Notifications
You must be signed in to change notification settings - Fork 32
Dependency updates #105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependency updates #105
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,7 +6,7 @@ branches: | |
language: android | ||
|
||
jdk: | ||
- oraclejdk8 | ||
- openjdk8 | ||
|
||
before_install: | ||
- pip install --user codecov | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,14 +4,14 @@ buildscript { | |
jcenter() | ||
} | ||
dependencies { | ||
classpath 'com.android.tools.build:gradle:3.1.3' | ||
classpath 'org.kt3k.gradle.plugin:coveralls-gradle-plugin:2.8.2' | ||
classpath "com.android.tools.build:gradle:3.5.2" | ||
classpath "org.kt3k.gradle.plugin:coveralls-gradle-plugin:2.8.2" | ||
classpath 'com.github.dcendents:android-maven-gradle-plugin:2.1' | ||
} | ||
} | ||
|
||
plugins { | ||
id 'com.github.ben-manes.versions' version '0.20.0' | ||
id "com.github.ben-manes.versions" version "0.27.0" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. fyi - i think we can get rid of this now that Gradle/Android Studio comes with built-in version checking There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah I've had mixed results with that. It works generally, but also sometimes misses dependencies that have not been fetched already by other projects or manually via this plugin. |
||
} | ||
|
||
allprojects { | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,5 @@ | ||
#Thu Mar 23 00:03:48 PDT 2017 | ||
distributionBase=GRADLE_USER_HOME | ||
distributionPath=wrapper/dists | ||
zipStoreBase=GRADLE_USER_HOME | ||
zipStorePath=wrapper/dists | ||
distributionUrl=https\://services.gradle.org/distributions/gradle-4.5.1-all.zip | ||
distributionUrl=https\://services.gradle.org/distributions/gradle-5.6.4-all.zip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there something about OkHttp 3.14.4 that was necessary for LiveQuery to be updated?
Note that Parse-SDK-Android explicitly adds a note that 3.13 and newer should be avoided, because OkHttp 3.13 bumps the minSdKVersion to Android 5.0: https://github.com/parse-community/Parse-SDK-Android/blob/master/parse/build.gradle#L31-L32
If 3.14 isn't an absolute requirement for something, I think LiveQuery should follow the same reasoning here, and stick to 3.12. Otherwise line 8 minSdkVersion 15 is wrong, or at the very least it's misleading.
I opened #113 to track this.