ci: Remove building types

[dplewis]

Pull Request

• Report security issues confidentially.
• Any contribution is under this license.
• Link this pull request to an issue.

Issue

Building types in the CI doesn't mean those built types are added to the code base.

Closes: #2460

Approach

By removing build:types from the CI we have ensure that the contributor adds a test whenever the types change or added. This let's us know that a generated type is missing because the test would fail.

Tasks

• Add tests
• Add changes to documentation (guides, repository pages, code comments)

[parse-github-assistant]

Thanks for opening this pull request!

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (a929019) to head (93da990).

Additional details and impacted files

@@            Coverage Diff            @@
##             alpha     #2462   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           64        64           
  Lines         6256      6256           
  Branches      1451      1476   +25     
=========================================
  Hits          6256      6256           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mtrezza]

This let's us know that a generated type is missing because the test would fail.

Which CI job would fail? Or should the CI build the types, compare and fail is there's a diff? I think that's how the Definitions check works in the CI.

[dplewis]

That’s even better, it will also catch if contributors manually change the files