Created base action #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It should be pointing to main
This should be required in #3
It is `token`, not `secret`
Tables do not allow for adding a link and this change should fix that
Oldest PRs first
|
@paritytech/opstooling I have finished testing the action. Find the related execution here. |
rzadp
approved these changes
Jan 9, 2024
src/index.ts
Outdated
| .then(() => { | ||
| logger.info("Operation completed"); | ||
| }) | ||
| .catch((e) => logger.error(e as Error)); |
There was a problem hiding this comment.
Should we maybe setFailed here? Otherwise the action will be green even if it failed unexpectedly?
There was a problem hiding this comment.
You are right. I got a brainfart when writing that part it seems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created base action with the ability to update PRs and print a summary of the results.
Resolves #2